-
Notifications
You must be signed in to change notification settings - Fork 279
feat: UserEvent pullToRefresh()
[WIP]
#1822
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mdjastrzebski
wants to merge
2
commits into
main
Choose a base branch
from
feat/user-event-pull-to-refresh
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Empty file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,69 @@ | ||
import * as React from 'react'; | ||
import { FlatList, RefreshControl, ScrollView, SectionList, Text } from 'react-native'; | ||
|
||
import { render, screen, userEvent } from '../../..'; | ||
|
||
describe('pullToRefresh()', () => { | ||
it('supports ScrollView', async () => { | ||
const onRefreshMock = jest.fn(); | ||
render( | ||
<ScrollView | ||
testID="view" | ||
refreshControl={<RefreshControl refreshing={false} onRefresh={onRefreshMock} />} | ||
/>, | ||
); | ||
const user = userEvent.setup(); | ||
|
||
await user.pullToRefresh(screen.getByTestId('view')); | ||
expect(onRefreshMock).toHaveBeenCalled(); | ||
}); | ||
|
||
it('supports FlatList', async () => { | ||
const onRefreshMock = jest.fn(); | ||
render( | ||
<FlatList | ||
testID="view" | ||
data={['A', 'B', 'C']} | ||
renderItem={({ item }) => <Text>{item}</Text>} | ||
refreshControl={<RefreshControl refreshing={false} onRefresh={onRefreshMock} />} | ||
/>, | ||
); | ||
const user = userEvent.setup(); | ||
|
||
await user.pullToRefresh(screen.getByTestId('view')); | ||
expect(onRefreshMock).toHaveBeenCalled(); | ||
}); | ||
|
||
it('supports SectionList', async () => { | ||
const onRefreshMock = jest.fn(); | ||
render( | ||
<SectionList | ||
testID="view" | ||
sections={[ | ||
{ title: 'Section 1', data: ['A', 'B', 'C'] }, | ||
{ title: 'Section 2', data: ['D', 'E', 'F'] }, | ||
]} | ||
renderItem={({ item }) => <Text>{item}</Text>} | ||
refreshControl={<RefreshControl refreshing={false} onRefresh={onRefreshMock} />} | ||
/>, | ||
); | ||
const user = userEvent.setup(); | ||
|
||
await user.pullToRefresh(screen.getByTestId('view')); | ||
expect(onRefreshMock).toHaveBeenCalled(); | ||
}); | ||
|
||
it('does not throw when RefreshControl is not set', async () => { | ||
render(<ScrollView testID="view" />); | ||
const user = userEvent.setup(); | ||
|
||
await expect(() => user.pullToRefresh(screen.getByTestId('view'))).not.toThrow(); | ||
}); | ||
|
||
it('does not throw when RefreshControl onRefresh is not set', async () => { | ||
render(<ScrollView testID="view" refreshControl={<RefreshControl refreshing={false} />} />); | ||
const user = userEvent.setup(); | ||
|
||
await expect(() => user.pullToRefresh(screen.getByTestId('view'))).not.toThrow(); | ||
}); | ||
}); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,28 @@ | ||
import type { ReactTestInstance } from 'react-test-renderer'; | ||
|
||
import act from '../../act'; | ||
import { ErrorWithStack } from '../../helpers/errors'; | ||
import { isHostScrollView } from '../../helpers/host-component-names'; | ||
import type { UserEventInstance } from '../setup'; | ||
|
||
export async function pullToRefresh( | ||
this: UserEventInstance, | ||
element: ReactTestInstance, | ||
): Promise<void> { | ||
if (!isHostScrollView(element)) { | ||
throw new ErrorWithStack( | ||
`pullToRefresh() works only with host "ScrollView" elements. Passed element has type "${element.type}".`, | ||
pullToRefresh, | ||
); | ||
} | ||
|
||
const refreshControl = element.props.refreshControl; | ||
if (refreshControl == null || typeof refreshControl.props.onRefresh !== 'function') { | ||
return; | ||
} | ||
|
||
// eslint-disable-next-line require-await | ||
await act(async () => { | ||
refreshControl.props.onRefresh(); | ||
}); | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Refresh Control Access Error & Misleading Documentation
Accessing
refreshControl.props.onRefresh
can lead to aTypeError
ifrefreshControl.props
is null or undefined. Separately, the error message forpullToRefresh()
is misleading, stating it only works withScrollView
elements whenFlatList
andSectionList
are also supported.