Repository navigation
feat(warm-pool): the warm pool boots or creates one device per queued request - #788
Merged
Merged
Conversation
Contributor
Author
Decision takenQuestion: with one ready device and two queued requests it would serve, does the warm pool create a device for the second request? The spec said yes; the build assumed no (review R2).
Why B: it is closest to today's behaviour (leasing owns the head's creation, a Non-goal of #771), it creates fewer devices, and it is easy to reverse. Reverting: treat a waiter matched to a ready device as the head in Written by an agent. |
Contributor
Author
Contributor
Author
Review ledger{"findings":[
{"id":"R1","role":"code","class":"retry schedule not read for waiter boots","outcome":"fixed","path":"src/core/warm-pool/policy.ts","fix":"8dbbe671"},
{"id":"R2","role":"spec","class":"spec case contradicted by assumption","outcome":"fixed","path":"src/core/warm-pool/policy.ts","fix":"0020a846"},
{"id":"R3","role":"claims","class":"architecture 13","outcome":"duplicate","path":"src/core/warm-pool/converger.ts","canonicalId":"R1"},
{"id":"R4","role":"claims","class":"incomplete doc wording","outcome":"fixed","path":"docs/CONFIGURATION.md","fix":"0020a846"},
{"id":"R5","role":"code","class":"testing 3, 9","outcome":"open","path":"src/core/warm-pool/converger.ts"}
]}Written by an agent. |
This was referenced Oct 20, 2026
V3RON
added this pull request to stack #791
October 20, 2026 20:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #774
Status
Implement: done (14/14 green, audited) Review: passed; R5 accepted open by the maintainer (2026-10-21) Hardware: n/a Gate: waiting for the stack
pnpm test:changedpasses.pnpm test:e2e e2e/warm-pool-reserve.test.ts e2e/warm-targets.test.tspasses.rg -n -i "behind a queued request" docs srcfinds only the new wording.rg -n "cpuCount" src/core/warm-pool/config.tsshows the default derived there, anddocs/CONFIGURATION.mdstates the formula.Assumptions
LeaseAcquisitionCoordinator). Without it, a request behind the head whose pool-made device was already ready stayed queued until some other event; the e2e found it.src/daemon/main.test.ts"creates no further device for a target once a stop is asked for" pinswarmPool.maxConcurrentBootsto 1, ase2e/warm-targets.test.tsdoes, because its two-target count relied on the old default.Review
Spec review: 1 blocking, 1 fixed, 0 notes. Code review: 2 blocking, 1 fixed, 0 notes. Claims review: 1 blocking, 1 fixed, 1 notes.
Rounds: 2. Tokens: 5.7M.
Runs: 15. Cost USD: 9.544. Agent seconds: 6655.
Assessment: incomplete
Written by an agent.