Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: interchain accounts #3182

Merged
merged 71 commits into from
Apr 5, 2024
Merged

feat!: interchain accounts #3182

merged 71 commits into from
Apr 5, 2024

Conversation

rootulp
Copy link
Collaborator

@rootulp rootulp commented Mar 15, 2024

Closes #3062
Opens #3207

@rootulp rootulp self-assigned this Mar 15, 2024
@rootulp rootulp mentioned this pull request Mar 15, 2024
3 tasks
@rootulp rootulp marked this pull request as ready for review April 4, 2024 17:02
evan-forbes
evan-forbes previously approved these changes Apr 4, 2024
Copy link
Member

@evan-forbes evan-forbes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice

@rootulp
Copy link
Collaborator Author

rootulp commented Apr 4, 2024

Gahhhh another merge conflict 💀

@celestia-bot celestia-bot requested a review from a team April 4, 2024 19:09
@rootulp rootulp requested a review from evan-forbes April 4, 2024 19:11
@rootulp rootulp enabled auto-merge (squash) April 4, 2024 19:11
@rootulp rootulp requested review from ninabarbakadze and removed request for a team, adlerjohn, liamsi, staheri14 and ninabarbakadze April 4, 2024 19:11
ninabarbakadze
ninabarbakadze previously approved these changes Apr 5, 2024
Copy link
Member

@ninabarbakadze ninabarbakadze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks Rootul and sorry for the million merge conflicts

cmwaters
cmwaters previously approved these changes Apr 5, 2024
Copy link
Contributor

@cmwaters cmwaters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like everything is plumbed together correctly. Also sorry for causing those merge conflicts 🙃

@rootulp rootulp dismissed stale reviews from cmwaters and ninabarbakadze via e5350c7 April 5, 2024 14:21
@celestia-bot celestia-bot requested review from a team and staheri14 and removed request for a team April 5, 2024 14:22
@rootulp rootulp requested review from ninabarbakadze and cmwaters and removed request for staheri14 April 5, 2024 14:22
@rootulp rootulp merged commit 21f53b3 into main Apr 5, 2024
34 checks passed
@rootulp rootulp deleted the rp/ica branch April 5, 2024 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Interchain Accounts
4 participants