Add spacetime_worker_reducer_returned_errors_total metric
#3613
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drogus
force-pushed
the
drogus/metrics-for-errors-and-panics
branch
4 times, most recently
from
74499c5 to
3fc3fa0
Compare
cloutiertyler
requested changes
Nov 10, 2025
Contributor
cloutiertyler
left a comment
cloutiertyler
left a comment
There was a problem hiding this comment.
Just think we should change/simplify the naming to not reference wasm
Collaborator
Author
Yeah, that makes sense. I wanted to go with the current convention, but we'll eventually probably rename it, too |
drogus
force-pushed
the
drogus/metrics-for-errors-and-panics
branch
from
3fc3fa0 to
6157a5f
Compare
cloutiertyler
approved these changes
Nov 12, 2025
Currently we have a metric for reducer panics called `spacetime_worker_wasm_instance_errors_total`. This commit adds a metric for tracking errors returned from the module, like for example an Err result in Rust, or throwing a SenderError in TypeScript
1 task
…errors-and-panics
drogus
force-pushed
the
drogus/metrics-for-errors-and-panics
branch
from
0ed5416 to
acb292d
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Currently, we have a metric for reducer panics called
spacetime_worker_wasm_instance_errors_total. This commit adds a metric for tracking errors returned from the module, like for example an Err result in Rust, or throwing a SenderError in TypeScriptThis will be needed for the web database overview dashboard, but it should be useful for tracking sender errors in general.
Expected complexity level and risk
1
Testing