Change spacetime_worker_wasm_instance_errors_total metric's labels
#3614
+8
−31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drogus
force-pushed
the
drogus/change-errors_metric_labels
branch
2 times, most recently
from
b0e38ba to
e38bc42
Compare
cloutiertyler
approved these changes
Nov 10, 2025
Contributor
cloutiertyler
left a comment
cloutiertyler
left a comment
There was a problem hiding this comment.
I think this makes a lot of sense.
drogus
force-pushed
the
drogus/change-errors_metric_labels
branch
from
e38bc42 to
0071360
Compare
There are two purpose for introducing the changes in this commit: 1. Decrease the cardinality of the metric, as caller id and connection id combination would result in way too many combinations 2. Add a database_identity label, which is much more useful for the metric
drogus
force-pushed
the
drogus/change-errors_metric_labels
branch
from
0071360 to
c5c372e
Compare
This was referenced Nov 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
There are two purposes for introducing the changes in this commit:
API and ABI breaking changes
I'm honestly not sure if metrics labels change is an API breaking change, I suppose not? For what it's worth, I don't think that anyone was relying on the labels I've removed.
Expected complexity level and risk
1
Testing