Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
07ee5d6
Updated to regex for namespace troubles
JasonAtClockwork Nov 15, 2025
82a3eaf
Fix linting issue
JasonAtClockwork Nov 15, 2025
55e4c93
Reviewed and we can remove the hacky global scope add for return type…
JasonAtClockwork Nov 17, 2025
599229d
Merge branch 'master' into jlarabie/csharp-view-ns
jdetter Nov 18, 2025
594c4d1
Added a Views tests to the C# regression tests
rekhoff Nov 18, 2025
7a9c0fe
client codegen fixes for views
joshua-spacetime Nov 18, 2025
988e13b
regen client bindings
joshua-spacetime Nov 18, 2025
a6ebefd
Merge branch 'joshua/fix/client-bindings-for-views' into jlarabie/csh…
rekhoff Nov 18, 2025
0188ee2
Merge branch 'jlarabie/csharp-view-ns' into rekhoff/csharp_replicatio…
rekhoff Nov 18, 2025
837a6a2
Updates the Views test of the C# regression tests
rekhoff Nov 19, 2025
4f7296d
Minor formatting update
rekhoff Nov 19, 2025
9a10dc1
fix client codegen for views
joshua-spacetime Nov 19, 2025
1afba75
Minor fixes
rekhoff Nov 19, 2025
056e3b6
Merge branch 'joshua/fix/client-bindings-for-views' into jlarabie/csh…
rekhoff Nov 19, 2025
8698dd3
Merge branch 'jlarabie/csharp-view-ns' into rekhoff/csharp_replicatio…
rekhoff Nov 19, 2025
cd36a95
Update sdks/csharp/examples~/regression-tests/client/Program.cs
rekhoff Nov 19, 2025
6340f61
Fixed up the C# module bindings for Views
JasonAtClockwork Nov 19, 2025
7022772
Merge branch 'master' into rekhoff/csharp_replication_test_with_views
joshua-spacetime Nov 20, 2025
ad7931e
revert sdk-test changes
joshua-spacetime Nov 20, 2025
2de6f15
revert rust codegen change
joshua-spacetime Nov 20, 2025
d418bb5
Update ExtraCompilationErrors.verified.txt
rekhoff Nov 20, 2025
a5adf19
Merge branch 'master' into rekhoff/csharp_replication_test_with_views
rekhoff Nov 20, 2025
773ecb0
Addressing some comments
rekhoff Nov 20, 2025
74d9581
Merge branch 'rekhoff/csharp_replication_test_with_views' of https://…
rekhoff Nov 20, 2025
3e6278e
Updated whitespace of client to match tests
rekhoff Nov 20, 2025
75648b0
Updated the codegen to have identical generation for RegisterView + V…
JasonAtClockwork Nov 20, 2025
d257d90
Update crates/bindings-csharp/Codegen/Module.cs
JasonAtClockwork Nov 20, 2025
5a137c5
Update crates/bindings-csharp/Codegen/Module.cs
JasonAtClockwork Nov 20, 2025
a64461e
Added more equality checks for the Views data
JasonAtClockwork Nov 20, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions crates/bindings-csharp/BSATN.Runtime/BSATN/Runtime.cs
Original file line number Diff line number Diff line change
Expand Up @@ -228,6 +228,12 @@ public void Write(BinaryWriter writer, Inner? value)

public AlgebraicType GetAlgebraicType(ITypeRegistrar registrar) =>
AlgebraicType.MakeOption(innerRW.GetAlgebraicType(registrar));

// Return a List BSATN serializer that can serialize this option as an array
public static List<Inner, InnerRW> GetListSerializer()
{
return new List<Inner, InnerRW>();
}
}

public readonly struct Bool : IReadWrite<bool>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -233,7 +233,7 @@ public partial struct TestDefaultFieldValues

var returnValue = Module.ViewDefWrongContext((SpacetimeDB.ViewContext)ctx);
^^^^^^^^^^^^^^^^^^^^^^^^^^^^
using var output = new System.IO.MemoryStream();
SpacetimeDB.BSATN.List<Player, Player.BSATN> returnRW = new();
*/
Message: Argument 1: cannot convert from 'SpacetimeDB.ViewContext' to 'SpacetimeDB.ReducerContext',
Severity: Error,
Expand Down Expand Up @@ -279,7 +279,7 @@ SpacetimeDB.Internal.Module.RegisterClientVisibilityFilter(global::Module.MY_THI

var returnValue = Module.ViewDefNoContext((SpacetimeDB.ViewContext)ctx);
^^^^^^^^^^^^^^^^
using var output = new System.IO.MemoryStream();
SpacetimeDB.BSATN.List<Player, Player.BSATN> returnRW = new();
*/
Message: No overload for method 'ViewDefNoContext' takes 1 arguments,
Severity: Error,
Expand All @@ -299,10 +299,10 @@ SpacetimeDB.Internal.Module.RegisterClientVisibilityFilter(global::Module.MY_THI
}
},
{/*

private static readonly SpacetimeDB.BSATN.ValueOption<NotSpacetimeType, NotSpacetimeType.BSATN> returnRW = new();
^^^^^
Params: [],
ReturnType: new SpacetimeDB.BSATN.ValueOption<NotSpacetimeType, NotSpacetimeType.BSATN>().GetAlgebraicType(registrar)
^^^^^
);
*/
Message: The type name 'BSATN' does not exist in the type 'NotSpacetimeType',
Severity: Error,
Expand All @@ -322,10 +322,10 @@ SpacetimeDB.Internal.Module.RegisterClientVisibilityFilter(global::Module.MY_THI
}
},
{/*
Params: [],
ReturnType: new SpacetimeDB.BSATN.ValueOption<NotSpacetimeType, NotSpacetimeType.BSATN>().GetAlgebraicType(registrar)
^^^^^
);
var returnValue = Module.ViewDefReturnsNotASpacetimeType((SpacetimeDB.AnonymousViewContext)ctx);
var listSerializer = SpacetimeDB.BSATN.ValueOption<NotSpacetimeType, NotSpacetimeType.BSATN>.GetListSerializer();
^^^^^
var listValue = ModuleRegistration.ToListOrEmpty(returnValue);
*/
Message: The type name 'BSATN' does not exist in the type 'NotSpacetimeType',
Severity: Error,
Expand Down
Loading
Loading