Export __call_view__ in C# #3691
Merged
+768
−216
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n_test_with_views
…n_test_with_views
Co-authored-by: joshua-spacetime <[email protected]> Signed-off-by: rekhoff <[email protected]>
joshua-spacetime
changed the base branch from
jlarabie/csharp-view-ns
to
master
…github.com/clockworklabs/SpacetimeDB into rekhoff/csharp_replication_test_with_views
rekhoff
commented
Nov 20, 2025
…iewDispatchers to make sure the indexes align
joshua-spacetime
approved these changes
Nov 20, 2025
Co-authored-by: joshua-spacetime <[email protected]> Signed-off-by: Jason Larabie <[email protected]>
Co-authored-by: joshua-spacetime <[email protected]> Signed-off-by: Jason Larabie <[email protected]>
joshua-spacetime
approved these changes
Nov 20, 2025
joshua-spacetime
changed the title
mamcx
pushed a commit
that referenced
this pull request
Nov 20, 2025
# Description of Changes 1. Updates the Replication Tests in `sdks/csharp/examples~/regression-tests` to include better coverage of Views 2. Added missing linkage for __call_view__ and __call_view_anon__ 3. Updated *ViewDispatcher Invoke to transform BSATN.ValueOption<> into BSATN.List<> 4. Fixed issues with the indexing of views to match correctly during __call_view__ and __call_view_anon__ # API and ABI breaking changes No # Expected complexity level and risk 2 # Testing - [x] Running `run-regression-tests.sh` passes. --------- Signed-off-by: rekhoff <[email protected]> Signed-off-by: Jason Larabie <[email protected]> Co-authored-by: Jason Larabie <[email protected]> Co-authored-by: John Detter <[email protected]> Co-authored-by: joshua-spacetime <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
sdks/csharp/examples~/regression-teststo include better coverage of ViewsAPI and ABI breaking changes
No
Expected complexity level and risk
2
Testing
run-regression-tests.shpasses.