Skip to content

Disable loop checks during unit tests#11900

Merged
Drulikar merged 3 commits intocmss13-devs:masterfrom
noelle-lavenza:fix/flaky-cnd-fail
Mar 9, 2026
Merged

Disable loop checks during unit tests#11900
Drulikar merged 3 commits intocmss13-devs:masterfrom
noelle-lavenza:fix/flaky-cnd-fail

Conversation

@noelle-lavenza
Copy link
Contributor

@noelle-lavenza noelle-lavenza commented Mar 7, 2026

About the pull request

Hopefully fixes a bunch of flaky create-and-destroy failures. Tentatively I'm saying this should close all the flaky create-and-destroy issues open, because a lot of them are too old to still have the relevant logs.

Also fixes an issue with roundstart lazyloading atoms, where they could end up qdeleted and then be lateinitialized in an invalid state. We now skip qdeleted atoms in the roundstart_loaders list.

The warning for enabling loop_checks is now ignored during unit testing and COMPILE_ALL_MAPS. However, it's still checked in the linting step, which ensures it won't accidentally get enabled on the live server.

Explain why it's good for the game

Fixes flaky create-and-destroy failures. What I think was happening is that the background loop checks caused stuff to start running in parallel; a background proc will yield at loop points, meaning stuff will run before/after it should.

Also fixes an issue that could cause certain atoms to runtime in Destroy() and fail to clean up all the references they ought to.

Testing Photographs and Procedure

This will only really be testable by checking CI.

Changelog

🆑 MoondancerPony
code: unit tests should have fewer flaky failures now
/:cl:

@noelle-lavenza noelle-lavenza requested a review from fira as a code owner March 7, 2026 14:11
@github-project-automation github-project-automation bot moved this to Awaiting Review in Review Backlog Mar 7, 2026
@cmss13-ci cmss13-ci bot added Code Improvement Make the code longer size/XS Denotes a PR that changes 0-19 lines, ignoring generated files. labels Mar 7, 2026
@cmss13-ci cmss13-ci bot added the Github We don't really know what else this belongs to label Mar 7, 2026
@github-project-automation github-project-automation bot moved this from Awaiting Review to Partially Approved / Mergeable in Review Backlog Mar 9, 2026
@Drulikar Drulikar added this pull request to the merge queue Mar 9, 2026
Merged via the queue into cmss13-devs:master with commit af9b8a8 Mar 9, 2026
27 checks passed
@github-project-automation github-project-automation bot moved this from Partially Approved / Mergeable to Merged in Review Backlog Mar 9, 2026
cmss13-ci bot added a commit that referenced this pull request Mar 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Code Improvement Make the code longer Github We don't really know what else this belongs to size/XS Denotes a PR that changes 0-19 lines, ignoring generated files.

Projects

Status: Merged

Development

Successfully merging this pull request may close these issues.

2 participants