Skip to content

Disable loop checks during unit tests #11900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Drulikar merged 3 commits into from
Mar 9, 2026
+10 −2
Merged

Disable loop checks during unit tests #11900

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8b25fa7
Disable loop checks during unit tests
noelle-lavenza Mar 7, 2026
30ecf7c
Fix an issue with qdeleted roundstart lazyloaders causing CI fails
noelle-lavenza Mar 7, 2026
28cd0d7
Ignore loop checks error in unit testing but not linters
noelle-lavenza Mar 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci_suite.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ jobs:
- name: Compile All Maps
run: |
source $HOME/BYOND/byond/bin/byondsetup
tools/build/build.sh --ci dm -DCIBUILDING -DCITESTING -DALL_MAPS
tools/build/build.sh --ci dm -DCIBUILDING -DCITESTING -DALL_MAPS -I"loop_checks"

find_all_maps:
if: ( !contains(github.event.head_commit.message, '[ci skip]') )
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/run_unit_tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ jobs:
- name: Compile Tests
run: |
source $HOME/BYOND/byond/bin/byondsetup
tools/build/build.sh --ci dm -DCIBUILDING -DANSICOLORS -Werror
tools/build/build.sh --ci dm -DCIBUILDING -DANSICOLORS -Werror -I"loop_checks"
- name: Run Tests
run: |
source $HOME/BYOND/byond/bin/byondsetup
Expand Down
2 changes: 2 additions & 0 deletions code/controllers/subsystem/atoms.dm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,6 +167,8 @@ SUBSYSTEM_DEF(atoms)

/datum/controller/subsystem/atoms/proc/lateinit_roundstart_atoms()
for(var/atom/A as anything in roundstart_loaders)
if(QDELETED(A))
continue
A.LateInitialize()
roundstart_loaders.Cut()

Expand Down
6 changes: 6 additions & 0 deletions code/game/world.dm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,12 @@ GLOBAL_LIST_INIT(reboot_sfx, file2list("config/reboot_sfx.txt"))
view = "15x15"
cache_lifespan = 0 //stops player uploaded stuff from being kept in the rsc past the current session
hub = "Exadv1.spacestation13"
// tick checking during reference finding in unit tests can cause knock-on failures elsewhere
// and really loop checks in CI can just do that too, so it's best to have them off
// todo: determine if this should just be #ifdef UNIT_TESTS for simplicity
#ifdef FIND_REF_NO_CHECK_TICK
loop_checks = FALSE
#endif

/world/New()
var/debug_server = world.GetConfig("env", "AUXTOOLS_DEBUG_DLL")
Expand Down