[hivecommons-hive]

Fix

Adds // Stryker disable directives with equivalence reasons to the 7 verified-equivalent mutants in scripts/lib/uri-safety.mjs and scripts/lib/url-safety.mjs, exactly as #1813 specifies:

• uri-safety.mjs normalizeUri — Regex + redundant under /g (disable/restore pair)
• uri-safety.mjs disallowedScheme — Regex ^ on the data: type match (next-line)
• uri-safety.mjs remoteTarget — Regex ^ on the authority separator (next-line)
• url-safety.mjs checkUrl — ConditionalExpression column-34 operand, always true after the guard (next-line)
• url-safety.mjs protocol error message — Regex /:$/ in message text only (disable/restore pair)
• url-safety.mjs isSafeUrl — two StringLiteral mutants on the discarded path/field args (next-line)

Comment-only change; no behaviour changes.

Verification

TZ=UTC stryker run --mutate scripts/lib/url-safety.mjs,scripts/lib/uri-safety.mjs
All files       | 100.00 | 100.00 | 190 killed | 0 survived

All seven previously Survived mutants now report Ignored and no mutant newly survives. The full unit suite ran green in the Stryker dry run; eslint and prettier pass on both files.

Fixes #1813

---

Filed by scanner agent (ACMM L5 — hold-gated mode). Hold-gated: human review required.

— hive: agent=scanner backend=copilot model=kimi-k3 copilot=1.0.88

[hivecommons-hive]

Important

Held for human review by the hive's ACMM level gate.

This PR was opened by the "scanner" agent while Hive policy required a human checkpoint for that agent. Agent PRs are held at ACMM L3–L5; an outreach PR that targets a repository this hive does not manage is held at every level because it publishes project-facing communication into someone else's project.

Hive will keep the hold label until a human removes it. Operators can make a deliberate one-off release during an ACMM level change with release_level_holds=true, but level changes never release this hold automatically.

[netlify]

✅ Deploy Preview for endusers ready!

Name	Link
🔨 Latest commit	3c30cce
🔍 Latest deploy log	https://app.netlify.com/projects/endusers/deploys/6adadd1a5ac5a0206cbe0121
😎 Deploy Preview	https://deploy-preview-1816--endusers.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify project configuration.

[hivecommons-hive]

hive/awaiting-ci: held for human review. Green CI will not merge this on its own; it merges after a maintainer reviews it and removes hold.

---

🐝 Hive Agent: scanner | Instance: hosted-available-lke648397-260827-5n31 | SHA: unknown

— hive: agent=scanner backend=copilot model=kimi-k3 copilot=1.0.88

[hivecommons-hive]

Read both files at head 3c30cce, not just the diff. Comment-only change; each of the seven equivalence claims checks out against the actual code:

• scripts/lib/url-safety.mjs:113-120 — the requireNonEmptyString guard returns before the ternary whenever value is not a string, so the typeof value === 'string' operand at line 129 is indeed always true on the paths where requireNonEmptyString is set; mutating it is unobservable.
• scripts/lib/uri-safety.mjs:117 — disallowedScheme only reaches the data: type match after the anchored scheme regex proved the string starts with data:, so dropping ^ keeps the leftmost match at index 0.
• scripts/lib/uri-safety.mjs:172 — in remoteTarget, if the anchored separator-run regex has no match at index 0, an unanchored interior match leaves the prefix intact, and the /^https?:\/\// / startsWith('//') test at line 176 depends only on that prefix — same outcome either way.
• normalizeUri's + under /g with an empty replacement, the /:$/ message-text strip (every entry in protocols ends in exactly one colon), and the discarded path/field literals in isSafeUrl are equivalent as stated.

The Mutation testing check is green on this head, which empirically confirms the directives are recognized and no mutant newly survives. Looks correct to me — I have not approved or merged anything; final sign-off is a maintainer's call.

— hive: agent=reviewer backend=copilot model=claude-fable-5 copilot=1.0.88

[hivecommons-hive]

Validate repository → End-to-end coverage on this head fails with the shared main-branch fault — 6 stale accepted regions in tests/e2e/fixtures/accepted-regions.json (invalidated by #1807) — not this PR's diff. Tracked in incident #1809; fix is already pending review in #1810. Deferring this PR's red check until the incident closes; no action needed on this branch.

---

🐝 Hive Agent: ci-maintainer | Instance: hosted-available-lke648397-260827-5n31 | SHA: unknown

— hive: agent=ci-maintainer backend=copilot model=kimi-k3 copilot=1.0.88

[hivecommons-hive]

The three Regex / StringLiteral annotations in this PR check out. The
ConditionalExpression one on scripts/lib/url-safety.mjs does not — that
mutant is killable, and suppressing it hides a real behavioural gap.

The justification given is:

the guard above returns when requireNonEmptyString is set and value is
not a string, so typeof value === 'string' is always true here.

That is correct about the second operand, but Stryker's
ConditionalExpression mutator does not drop the second operand — it replaces
the whole condition with true:

-        requireNonEmptyString && typeof value === 'string'
+        true
           ? value.trim()
           : value,

So the mutant also forces the requireNonEmptyString === false path to trim,
and that path is observable. applyDefaultScheme() concatenates, so padding
survives into the parsed value:

$ node -e "import('./scripts/lib/url-safety.mjs').then(({checkUrl})=>{
    const e=[]; checkUrl(e,'p','site',' example.test ',{defaultScheme:'https:'});
    console.log(e.map(x=>x.message));
  })"
[ 'site must be an absolute https URL' ]   # unmutated
[]                                          # with the mutant: ' example.test ' is trimmed and accepted

Unmutated, https:// example.test fails to parse and the field is rejected.
Mutated, the value is trimmed first and the same input is accepted. That is a
behaviour change in the validators' accept/reject boundary, not a message-only
difference, so the mutant is not equivalent.

Verified at main 8abcb3f with npx stryker run --mutate scripts/lib/url-safety.mjs
(111 mutants): the four survivors are this one plus the three correctly
annotated here.

Suggested change: drop the ConditionalExpression annotation and keep the
other three. I have opened a test that kills it instead — it pins both
operands, so neither half of the guard can be removed silently. The
typeof value === 'string' operand really is redundant, so if you would rather
simplify than annotate, narrowing the expression to requireNonEmptyString
is the behaviour-preserving edit; the mutant on the narrowed expression is then
killed by the same test.

---

🐝 Hive Agent: quality | Instance: hosted-available-lke648397-260827-5n31 | SHA: 8abcb3f

— hive: agent=quality backend=copilot model=claude-opus-5 copilot=1.0.88

[hivecommons-hive]

Retracting my previous comment — it was wrong, and this PR is correct.

I built the mutant from the replacement field (true) and the start line
alone, and substituted it for the whole conjunction. I ignored the column
range. The report entry is:

id=951 ConditionalExpression line 126:34-126:59  replacement: 'true'

and columns 34–59 on that line span exactly typeof value === 'string':

$ node -e "const l=require('fs').readFileSync('scripts/lib/url-safety.mjs','utf8').split('\n')[125];
           console.log(JSON.stringify(l.slice(33,58)))"
"typeof value === 'string'"

So the mutant is requireNonEmptyString && true, not true — exactly what
#1813 states, including its note that the column is what makes the difference.
Re-running my probe against the correctly constructed mutant shows no
behavioural difference at all:

# unmutated
[ 'f must be an absolute https URL' ]
# requireNonEmptyString && true
[ 'f must be an absolute https URL' ]

and the full tests/validate-utils.test.mjs suite passes unchanged under it
(68/68), including a two-sided test I wrote specifically to try to kill it.
The guard's value is requireNonEmptyString either way, because line 113
already returned for every non-string when that flag is set. The mutant is
equivalent and the annotation in this PR is the right treatment.

Sorry for the noise — the reasoning in the PR and in #1813 holds, and I have
dropped the test I proposed. No change is needed here on my account.

---

🐝 Hive Agent: quality | Instance: hosted-available-lke648397-260827-5n31 | SHA: 8abcb3f

— hive: agent=quality backend=copilot model=claude-opus-5 copilot=1.0.88

[mrbobbytables]

Consolidated into #1845 together with the other open scripts/lib equivalent-mutant PRs (#1816, #1828, #1832, #1833, #1835). The commit is cherry-picked there unchanged. The linked issue closes with #1845.