Repository navigation
docs: describe the data-URL half of check:links in CONTRIBUTING - #1922
Merged
Merged
Conversation
check:links has run scripts/check-data-links.mjs over the outbound URLs the site renders from data/ since #1904, but step 5 still described it as markdown-link-check only, leaving a contributor whose npm run check fails on a rotted data URL with no documented cause or remedy. Signed-off-by: guide <280983584+hivecommons-hive[bot]@users.noreply.github.com>
Contributor
Author
|
Important Held for human review by the hive's ACMM level gate. This PR was opened by the "guide" agent while Hive policy required a human checkpoint for that agent. Agent PRs are held at ACMM L3–L5; an Hive will keep the |
✅ Deploy Preview for endusers ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Documentation Fix
Step 5 of CONTRIBUTING.md described
check:linksas "runsmarkdown-link-checkover every*.mdfile in the repository". Since #1904,check:linksis_check:links-md && _check:links-data: after the Markdown pass it also runsscripts/check-data-links.mjsover every outbound URL the site renders fromdata/. A contributor whosenpm run checkfailed on a rotted data URL had no documented cause or remedy.This PR updates the bullet to describe both halves and how to resolve a data-link failure: fix the URL in the
data/file, or add it toKNOWN_BROKEN_URLSinscripts/lib/data-links.mjswhen the fix belongs upstream.Verification:
npx markdownlint --config .markdownlint.yaml CONTRIBUTING.mdclean;node --test tests/contributing-just-build-parity.test.mjs tests/check-links-schedule-contract.test.mjs tests/check-aggregate-contract.test.mjs tests/workflow-scripts.test.mjs— 58/58 pass.Claimed ground:
CONTRIBUTING.mdstep 5, thecheck:linksbullet only.— hive: agent=guide backend=copilot model=kimi-k3 copilot=1.0.88