Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.travis.yml: Add sentinel job #2541

Merged
merged 2 commits into from
Jul 7, 2018
Merged

Conversation

jayvdb
Copy link
Member

@jayvdb jayvdb commented Jun 19, 2018

This makes Python 3.6 the sentinel job,
so it runs by itself initially and causes
all other jobs to be cancelled if it fails.

For short term contributors: we understand that getting your commits well
defined like we require is a hard task and takes some learning. If you
look to help without wanting to contribute long term there's no need
for you to learn this. Just drop us a message and we'll take care of brushing
up your stuff for merge!

Checklist

  • I read the commit guidelines and I've followed
    them.
  • I ran coala over my code locally. (All commits have to pass
    individually.
    It is not sufficient to have "fixup commits" on your PR,
    our bot will still report the issues for the previous commit.) You will
    likely receive a lot of bot comments and build failures if coala does not
    pass on every single commit!

After you submit your pull request, DO NOT click the 'Update Branch' button.
When asked for a rebase, consult coala.io/rebase
instead.

Please consider helping us by reviewing other peoples pull requests as well:

The more you review, the more your score will grow at coala.io and we will
review your PRs faster!

@jayvdb
Copy link
Member Author

jayvdb commented Jun 19, 2018

c.f. coala/coala#5542 for the main repo

@jayvdb
Copy link
Member Author

jayvdb commented Jun 19, 2018

Turns out that caching is working, but something is causing the R libraries to be rebuilt on Python 3.6.
Python3.6 https://travis-ci.org/coala/coala-bears/jobs/393940806
Python3.6 https://travis-ci.org/coala/coala-bears/jobs/394084183

Python3.4 https://travis-ci.org/coala/coala-bears/jobs/394084185

This change would make a bears build take twice as long to complete all of the jobs, which means close to 1.5 hrs for a full rebuild.
But we could make the Python 3.6 job a 'thin' python-only job (importing a bit of logic from #1386)

@jayvdb
Copy link
Member Author

jayvdb commented Jun 19, 2018

Actually splitting the jobs by runtime makes the sentinel useless, as we can tell travis which job should go first.

@jayvdb
Copy link
Member Author

jayvdb commented Jul 6, 2018

Example: failure in 2.9 minutes

https://travis-ci.org/jayvdb/coala-bears/builds/400680800

@jayvdb jayvdb mentioned this pull request Jul 6, 2018
2 tasks
@Makman2
Copy link
Member

Makman2 commented Jul 7, 2018

ack c8f29f4 08d4ded

@Makman2
Copy link
Member

Makman2 commented Jul 7, 2018

@gitmate-bot rebase

@gitmate-bot
Copy link
Collaborator

Hey! I'm GitMate.io! This pull request is being rebased automatically. Please DO NOT push while rebase is in progress or your changes would be lost permanently ⚠️

jayvdb added 2 commits July 7, 2018 19:08
This adds a Python 3.6 'coala-ci' sentinel job for builds
except pushes to master, so it runs by itself initially
to check code style only, and causes all other jobs to
be cancelled if it fails.
@gitmate-bot
Copy link
Collaborator

Automated rebase with GitMate.io was successful! 🎉

@jayvdb
Copy link
Member Author

jayvdb commented Jul 7, 2018

@gitmate-bot ff

@gitmate-bot
Copy link
Collaborator

Hey! I'm GitMate.io! This pull request is being fastforwarded automatically. Please DO NOT push while fastforward is in progress or your changes would be lost permanently ⚠️

@gitmate-bot
Copy link
Collaborator

Automated fastforward with GitMate.io was successful! 🎉

@gitmate-bot gitmate-bot merged commit 98999c5 into coala:master Jul 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants