Add custom programs to ProgramCache #20496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Store and retrieve custom user-defined programs to ProgramCache.
Mee-gu
approved these changes
Jul 3, 2020
Mee-gu
reviewed
Jul 3, 2020
|
|
||
| void ProgramCache::addCustomProgram(const std::string &key, backend::Program *program) | ||
| { | ||
| _cachedCustomPrograms.emplace(key, program); |
There was a problem hiding this comment.
need release old program if key is already exist in _cachedCustomPrograms.
There was a problem hiding this comment.
I have fixed this in ironhidegames@69f3933
Should I make a new PR?
There was a problem hiding this comment.
I have made a new PR: #20550
one2world
added a commit
to one2world/cocos2d-x
that referenced
this pull request
Sep 20, 2020
Add custom programs to ProgramCache (cocos2d#20496)
Xrysnow
pushed a commit
to Xrysnow/cocos2d-x
that referenced
this pull request
Dec 10, 2020
Store and retrieve custom user-defined programs to ProgramCache.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Store and retrieve custom user-defined programs in ProgramCache.
This feature was in v3 but not present in v4.