Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix memory leak when adding a custom program which already exists #20550

Open
wants to merge 3 commits into
base: v4
Choose a base branch
from

Conversation

bolino
Copy link
Contributor

@bolino bolino commented Jul 10, 2020

Release previous program and eraste it from cache before inserting new one.

This is fix for my previous PR: #20496

Juan Andres added 2 commits April 15, 2020 11:15
Store and retrieve custom user-defined programs to ProgramCache.
Release previous program and eraste it from cache before inserting
new one.
@minggo
Copy link
Contributor

minggo commented Jul 13, 2020

@bolino could you please fix conflict and compiling error. Thanks.

@bolino
Copy link
Contributor Author

bolino commented Jul 16, 2020

@bolino could you please fix conflict and compiling error. Thanks.

Hey, I updated the PR but I'm a bit confused since checks were successful yet the fix commit (69f3933) show with a red cross.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants