fix: ANTIGRAVITY_PROVIDER_CONFIG missing new model from antigravity #812
Conversation
|
All contributors have signed the CLA. Thank you! ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
|
please make sure that the related tests pass |
- Update existing test to verify all models include full specifications. - Add new tests to ensure Antigravity and Gemini CLI models have correct naming conventions. - Introduce checks for models with variants to confirm the presence of required properties.
|
Updated test for antigravty model and pass |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
2 issues found across 1 file (changes from recent commits).
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name="src/cli/config-manager.test.ts">
<violation number="1" location="src/cli/config-manager.test.ts:182">
P2: Generated agent model still uses removed variant id `antigravity-gemini-3-pro-high`, which no longer exists in provider config</violation>
<violation number="2" location="src/cli/config-manager.test.ts:257">
P2: Test does not verify variants contain required thinkingConfig/thinkingLevel despite test intent</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
| const required = [ | ||
| "antigravity-gemini-3-pro-high", | ||
| "antigravity-gemini-3-pro-low", | ||
| "antigravity-gemini-3-pro", |
There was a problem hiding this comment.
P2: Generated agent model still uses removed variant id antigravity-gemini-3-pro-high, which no longer exists in provider config
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At src/cli/config-manager.test.ts, line 182:
<comment>Generated agent model still uses removed variant id `antigravity-gemini-3-pro-high`, which no longer exists in provider config</comment>
<file context>
@@ -170,24 +170,32 @@ describe("fetchNpmDistTags", () => {
const required = [
- "antigravity-gemini-3-pro-high",
- "antigravity-gemini-3-pro-low",
+ "antigravity-gemini-3-pro",
"antigravity-gemini-3-flash",
+ "antigravity-claude-sonnet-4-5",
</file context>
| expect(Object.keys(model.variants).length).toBeGreaterThan(0) | ||
| } |
There was a problem hiding this comment.
P2: Test does not verify variants contain required thinkingConfig/thinkingLevel despite test intent
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At src/cli/config-manager.test.ts, line 257:
<comment>Test does not verify variants contain required thinkingConfig/thinkingLevel despite test intent</comment>
<file context>
@@ -198,6 +206,57 @@ describe("config-manager ANTIGRAVITY_PROVIDER_CONFIG", () => {
+ const model = models[key]
+ // #then variants should exist
+ expect(model.variants).toBeTruthy()
+ expect(Object.keys(model.variants).length).toBeGreaterThan(0)
+ }
+ })
</file context>
| expect(Object.keys(model.variants).length).toBeGreaterThan(0) | |
| } | |
| const variantEntries = Object.values(model.variants) | |
| expect(variantEntries.length).toBeGreaterThan(0) | |
| for (const variant of variantEntries) { | |
| expect(variant.thinkingLevel || variant.thinkingConfig).toBeTruthy() | |
| } |
|
I know some of these failures are preexisting.. I may need to clean up the |
|
Antigravity is no longer supported directly in oMo. It will still work but config will happen in OpenCode itself. |
3 participants
Summary
Changes
Screenshots
Testing
bun run typecheck bun testRelated Issues
Closes #811
Summary by cubic
Fixes missing Antigravity models in the provider config so users regain access to the models they had. Aligns the Google provider models with the opencode-antigravity-auth schema, including new variants.
Written for commit e813693. Summary will update on new commits.