-
Notifications
You must be signed in to change notification settings - Fork 2k
fix: ANTIGRAVITY_PROVIDER_CONFIG missing new model from antigravity #812
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -170,24 +170,32 @@ describe("fetchNpmDistTags", () => { | |||||||||||||||
| }) | ||||||||||||||||
|
|
||||||||||||||||
| describe("config-manager ANTIGRAVITY_PROVIDER_CONFIG", () => { | ||||||||||||||||
| test("Gemini models include full spec (limit + modalities)", () => { | ||||||||||||||||
| test("All models include full spec (limit + modalities)", () => { | ||||||||||||||||
| const google = (ANTIGRAVITY_PROVIDER_CONFIG as any).google | ||||||||||||||||
| expect(google).toBeTruthy() | ||||||||||||||||
|
|
||||||||||||||||
| const models = google.models as Record<string, any> | ||||||||||||||||
| expect(models).toBeTruthy() | ||||||||||||||||
|
|
||||||||||||||||
| // #given all models in the config | ||||||||||||||||
| const required = [ | ||||||||||||||||
| "antigravity-gemini-3-pro-high", | ||||||||||||||||
| "antigravity-gemini-3-pro-low", | ||||||||||||||||
| "antigravity-gemini-3-pro", | ||||||||||||||||
| "antigravity-gemini-3-flash", | ||||||||||||||||
| "antigravity-claude-sonnet-4-5", | ||||||||||||||||
| "antigravity-claude-sonnet-4-5-thinking", | ||||||||||||||||
| "antigravity-claude-opus-4-5-thinking", | ||||||||||||||||
| "gemini-2.5-flash", | ||||||||||||||||
| "gemini-2.5-pro", | ||||||||||||||||
| "gemini-3-flash-preview", | ||||||||||||||||
| "gemini-3-pro-preview", | ||||||||||||||||
| ] | ||||||||||||||||
|
|
||||||||||||||||
| // #when checking each model | ||||||||||||||||
| for (const key of required) { | ||||||||||||||||
| const model = models[key] | ||||||||||||||||
| // #then each model should have required properties | ||||||||||||||||
| expect(model).toBeTruthy() | ||||||||||||||||
| expect(typeof model.name).toBe("string") | ||||||||||||||||
| expect(model.name.includes("(Antigravity)")).toBe(true) | ||||||||||||||||
|
|
||||||||||||||||
| expect(model.limit).toBeTruthy() | ||||||||||||||||
| expect(typeof model.limit.context).toBe("number") | ||||||||||||||||
|
|
@@ -198,6 +206,57 @@ describe("config-manager ANTIGRAVITY_PROVIDER_CONFIG", () => { | |||||||||||||||
| expect(Array.isArray(model.modalities.output)).toBe(true) | ||||||||||||||||
| } | ||||||||||||||||
| }) | ||||||||||||||||
|
|
||||||||||||||||
| test("Antigravity models have (Antigravity) in name", () => { | ||||||||||||||||
| const models = (ANTIGRAVITY_PROVIDER_CONFIG as any).google.models as Record<string, any> | ||||||||||||||||
|
|
||||||||||||||||
| const antigravityModels = [ | ||||||||||||||||
| "antigravity-gemini-3-pro", | ||||||||||||||||
| "antigravity-gemini-3-flash", | ||||||||||||||||
| "antigravity-claude-sonnet-4-5", | ||||||||||||||||
| "antigravity-claude-sonnet-4-5-thinking", | ||||||||||||||||
| "antigravity-claude-opus-4-5-thinking", | ||||||||||||||||
| ] | ||||||||||||||||
|
|
||||||||||||||||
| for (const key of antigravityModels) { | ||||||||||||||||
| expect(models[key].name.includes("(Antigravity)")).toBe(true) | ||||||||||||||||
| } | ||||||||||||||||
| }) | ||||||||||||||||
|
|
||||||||||||||||
| test("Gemini CLI models have (Gemini CLI) in name", () => { | ||||||||||||||||
| const models = (ANTIGRAVITY_PROVIDER_CONFIG as any).google.models as Record<string, any> | ||||||||||||||||
|
|
||||||||||||||||
| const geminiCliModels = [ | ||||||||||||||||
| "gemini-2.5-flash", | ||||||||||||||||
| "gemini-2.5-pro", | ||||||||||||||||
| "gemini-3-flash-preview", | ||||||||||||||||
| "gemini-3-pro-preview", | ||||||||||||||||
| ] | ||||||||||||||||
|
|
||||||||||||||||
| for (const key of geminiCliModels) { | ||||||||||||||||
| expect(models[key].name.includes("(Gemini CLI)")).toBe(true) | ||||||||||||||||
| } | ||||||||||||||||
| }) | ||||||||||||||||
|
|
||||||||||||||||
| test("Thinking models have variants with thinkingConfig or thinkingLevel", () => { | ||||||||||||||||
| const models = (ANTIGRAVITY_PROVIDER_CONFIG as any).google.models as Record<string, any> | ||||||||||||||||
|
|
||||||||||||||||
| // #given models with variants | ||||||||||||||||
| const modelsWithVariants = [ | ||||||||||||||||
| "antigravity-gemini-3-pro", | ||||||||||||||||
| "antigravity-gemini-3-flash", | ||||||||||||||||
| "antigravity-claude-sonnet-4-5-thinking", | ||||||||||||||||
| "antigravity-claude-opus-4-5-thinking", | ||||||||||||||||
| ] | ||||||||||||||||
|
|
||||||||||||||||
| // #when checking variants | ||||||||||||||||
| for (const key of modelsWithVariants) { | ||||||||||||||||
| const model = models[key] | ||||||||||||||||
| // #then variants should exist | ||||||||||||||||
| expect(model.variants).toBeTruthy() | ||||||||||||||||
| expect(Object.keys(model.variants).length).toBeGreaterThan(0) | ||||||||||||||||
| } | ||||||||||||||||
|
Comment on lines
+257
to
+258
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. P2: Test does not verify variants contain required thinkingConfig/thinkingLevel despite test intent Prompt for AI agents
Suggested change
|
||||||||||||||||
| }) | ||||||||||||||||
| }) | ||||||||||||||||
|
|
||||||||||||||||
| describe("generateOmoConfig - GitHub Copilot fallback", () => { | ||||||||||||||||
|
|
||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
P2: Generated agent model still uses removed variant id
antigravity-gemini-3-pro-high, which no longer exists in provider configPrompt for AI agents