[stacked 2/5] metrics: add de-facto standard collectors. #404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klihub
force-pushed
the
metrics/standard-collectors
branch
2 times, most recently
from
df856a6
to
095de2c
Compare
klihub
changed the title
pfl
approved these changes
Nov 12, 2024
Yes, this is effectively a single-commit PR, it's just stacked on top of #403. |
klihub
force-pushed
the
metrics/standard-collectors
branch
4 times, most recently
from
0ce588f
to
be87761
Compare
klihub
changed the title
klihub
changed the title
klihub
changed the title
klihub
force-pushed
the
metrics/standard-collectors
branch
2 times, most recently
from
83023be
to
3900e8f
Compare
Rework our metrics collector registry to take care of most of the necessary bits for metrics registration, collection and gathering. Use the prometheus-provided namespacing and subsystems to put all generated metrics under a prefix and provide additional grouping. Signed-off-by: Krisztian Litkey <[email protected]>
Update cgroupstats collector for the reworked metrics registry. Split out automatic registration to a register subpackage. Signed-off-by: Krisztian Litkey <[email protected]>
Remove the old resmgr-triggered polling of policy metrics and the old resmgr-level polling policy metrics collector. Implement policy metrics collection in the policy package itself. Signed-off-by: Krisztian Litkey <[email protected]>
Remove the old opencensus-based prometheus exporter. Rework prometheus exporting using our update metrics registry and a promhttp /metrics-handler. Signed-off-by: Krisztian Litkey <[email protected]>
Add configuration bits for controlling which metrics are collected. Enable collection of policy metrics by default. Signed-off-by: Krisztian Litkey <[email protected]>
Remove obsolete and unused option entries. Give a warning about using the now-obsolete '-metrics-interval' argument. It's used unconditionally by our existing Helm charts, so we'll phase it out a bit more gently. Signed-off-by: Krisztian Litkey <[email protected]>
Add a metrics/collectors subpackage. When imported it pulls in and registers the fairly standard buildinfo, process and golang runtime collectors. Turn on the build info collector by default. Signed-off-by: Krisztian Litkey <[email protected]>
klihub
force-pushed
the
metrics/standard-collectors
branch
from
3900e8f
to
c55507e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes: This PR is stacked on top of #403.
Add a
metrics/collectorssubpackage to register the fairly standardbuildinfo,processandgolangruntime collectors. Turn on thebuildinfocollector by default.