installation: adjust make option - #626
Open
stefanfrede wants to merge 1 commit into
Open
Conversation
Podman's Makefile declares `BUILDTAGS ?=` as a computed list that includes `$(shell hack/systemd_tag.sh)`, which emits `systemd` when the libsystemd headers are present. Setting `BUILDTAGS=` on the command line **replaces** that list rather than adding to it, so `systemd` is dropped.
| ``` | ||
|
|
||
| Podman supports optional build tags for compiling support of various features. | ||
| To add build tags to the make option the `BUILDTAGS` variable must be set, for example: |
Member
There was a problem hiding this comment.
I think you want
Suggested change
| To add build tags to the make option the `BUILDTAGS` variable must be set, for example: | |
| To add build tags while keeping auto-detected defaults, set EXTRA_BUILDTAGS, for example: |
|
|
||
| If you are building on RHEL8 you'll need to build without btrfs support due to [it being removed](https://docs.redhat.com/en/documentation/red_hat_enterprise_linux/8/html/considerations_in_adopting_rhel_8/file-systems-and-storage_considerations-in-adopting-rhel-8#btrfs-has-been-removed_file-systems-and-storage): | ||
| ``` | ||
| make BUILDTAGS="btrfs_noversion exclude_graphdriver_btrfs" |
Member
There was a problem hiding this comment.
You need EXTRA_BUILDTAGS here too
Suggested change
| make EXTRA_BUILDTAGS="btrfs_noversion exclude_graphdriver_btrfs" |
Please search for other instances.
| git clone https://github.com/opencontainers/runc.git $GOPATH/src/github.com/opencontainers/runc | ||
| cd $GOPATH/src/github.com/opencontainers/runc | ||
| make BUILDTAGS="selinux seccomp" | ||
| make EXTRA_BUILDTAGS="selinux seccomp" |
Member
There was a problem hiding this comment.
Suggested change
| make EXTRA_BUILDTAGS="selinux seccomp" | |
| make RUNC_BUILDTAGS="selinux" |
runc default already includes seccomp
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Podman's Makefile declares
BUILDTAGS ?=as a computed list that includes$(shell hack/systemd_tag.sh), which emitssystemdwhen the libsystemd headers are present.Setting
BUILDTAGS=on the command line replaces that list rather than adding to it, sosystemdis dropped.Concisely describe the change
Use
EXTRA_BUILDTAGSto append to the computed defaults.BUILDTAGSis replacing them.Before screenshot / screen recording
After screenshot / screen recording
Checklist
Ensure you have completed the following checklist for your pull request to be reviewed:
commits. (
git commit -s). (If needed, usegit commit -s --amend). The author email must matchthe sign-off email address. See CONTRIBUTING.md
for more information.
Fixes: #00000in commit message (if applicable)