-
Notifications
You must be signed in to change notification settings - Fork 152
installation: adjust make option #626
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
stefanfrede
wants to merge
1
commit into
containers:main
Choose a base branch
from
stefanfrede:install/building-from-source
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+5
−5
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -483,7 +483,7 @@ To double-check, the first line of the `runc --version` output should show `vers | |||||
| ```bash | ||||||
| git clone https://github.com/opencontainers/runc.git $GOPATH/src/github.com/opencontainers/runc | ||||||
| cd $GOPATH/src/github.com/opencontainers/runc | ||||||
| make BUILDTAGS="selinux seccomp" | ||||||
| make EXTRA_BUILDTAGS="selinux seccomp" | ||||||
| sudo cp runc /usr/bin/runc | ||||||
| ``` | ||||||
|
|
||||||
|
|
@@ -524,24 +524,24 @@ First, ensure that the `go version` that is found first on the $PATH is 1.23.x o | |||||
| ```bash | ||||||
| git clone https://github.com/containers/podman/ | ||||||
| cd podman | ||||||
| make BUILDTAGS="selinux seccomp" PREFIX=/usr | ||||||
| make EXTRA_BUILDTAGS="selinux seccomp" PREFIX=/usr | ||||||
| sudo env PATH=$PATH make install PREFIX=/usr | ||||||
| ``` | ||||||
|
|
||||||
| #### Build Tags | ||||||
|
|
||||||
| Otherwise, if you do not want to build Podman with seccomp or selinux support you can add `BUILDTAGS=""` when running make. | ||||||
| If you want to build Podman and auto-detect tags, omit the `BUILDTAGS` option when running make. | ||||||
|
|
||||||
| ```bash | ||||||
| make BUILDTAGS="" | ||||||
| make | ||||||
| sudo make install | ||||||
| ``` | ||||||
|
|
||||||
| Podman supports optional build tags for compiling support of various features. | ||||||
| To add build tags to the make option the `BUILDTAGS` variable must be set, for example: | ||||||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think you want
Suggested change
|
||||||
|
|
||||||
| ```bash | ||||||
| make BUILDTAGS='seccomp apparmor' | ||||||
| make EXTRA_BUILDTAGS='seccomp apparmor' | ||||||
| ``` | ||||||
|
|
||||||
| If you are building on RHEL8 you'll need to build without btrfs support due to [it being removed](https://docs.redhat.com/en/documentation/red_hat_enterprise_linux/8/html/considerations_in_adopting_rhel_8/file-systems-and-storage_considerations-in-adopting-rhel-8#btrfs-has-been-removed_file-systems-and-storage): | ||||||
|
|
||||||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
runc default already includes seccomp