Main convert - #383
Merged
Merged
Conversation
Update pages, publish-package, and release-please workflows to use Node 22, matching the QA workflow that already runs on Node 22.
Update Serving API - from backend PR #6390
chore/sync-main
Update Serving API - from backend PR #6424
…ookie-condition feat: adding cookie (exist , not exist) conditions
Bumps @convertcom/js-sdk-types peer range to >=3.11.0 across api, bucketing, data, event, experience, js-sdk, rules, segments; bumps @convertcom/js-sdk-rules to >=2.1.4 in data, js-sdk, segments. Picked up by yarn 4 during a local build. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Reorders the QA workflow to install yarn deps before Playwright browsers, and uses `yarn playwright install` instead of `npx`. With `npx` running before `yarn`, node_modules was empty so npx fetched the latest playwright from npm (1.60.0 today) and downloaded chromium binaries for that revision. The job then ran tests against the project's pinned @playwright/test@1.59.1, which expects a different chromium-headless-shell build, hitting "Executable doesn't exist at .../chromium_headless_shell-1217/..." on every browser test. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Update package versions
Update Serving API - from backend PR #6604
The yarn.lock on main-convert was bumped to lockfile metadata `version: 9` by a local install with yarn >=4.11. The backend's V1 tracking build runs `yarn install` in immutable mode under yarn 4.10.3 (per `public/js/tracking/package.json` packageManager field), which writes `version: 8` lockfiles — triggering YN0028 and failing staging deploys. Pinning `packageManager: yarn@4.10.3` here makes the toolchain explicit and prevents future drift when contributors run install with a newer yarn. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
fix(ci): pin yarn to 4.10.3 and regenerate lockfile
Context.runExperience and Context.runExperiences rebuilt a fresh attributes object with only four hardcoded keys (visitorProperties, locationProperties, updateVisitorProperties, environment) before forwarding to ExperienceManager.selectVariation/selectVariations. This silently dropped every other BucketingAttributes field — enableTracking, forceVariationId, ignoreLocationProperties, typeCasting, experienceKeys — so callers opting out of tracking, forcing a variation, or ignoring location targeting were silently ignored. DataManager._getBucketingByField destructures these by name with enableTracking defaulting to `true`, which is how the opt-out was being lost. Switch to spread-then-override so all caller-supplied attributes pass through while still applying the two transforms Context must do: merging visitorProperties via getVisitorProperties() and defaulting environment to the Context's own environment. Add tests covering forwarding of enableTracking, forceVariationId, ignoreLocationProperties, and updateVisitorProperties through both runExperience and runExperiences. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
…-attributes fix(context): forward all BucketingAttributes to ExperienceManager
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the package manager to Yarn 4 and increments several dependency versions. It refactors the JS SDK context to forward bucketing attributes using spread syntax and introduces new cookie existence rules ('exists' and 'doesNotExist') with corresponding comparison utilities and tests. Additionally, it converts numerous type definitions into enums. Reviewers recommend using camelCase for the new comparison methods, restoring documentation lost during enum conversion, and ensuring that new types like PlanStatus and Products are implemented as enums to match the project's refactoring goals.
JosephSamirL
approved these changes
May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.