Main convert

.github/workflows/pages.yml

@@ -11,7 +11,7 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        node: [18]
+        node: [22]
     # Steps represent a sequence of tasks that will be executed as part of the job
     steps:
       - uses: actions/setup-node@v1

.github/workflows/publish-package.yml

@@ -15,7 +15,7 @@ jobs:
       # Setup .npmrc file to publish to npm
       - uses: actions/setup-node@v4
         with:
-          node-version: '18.x'
+          node-version: '22.x'
           registry-url: 'https://registry.npmjs.org'
       - name: Resolve tag
         run: echo "RELEASE_TAG=${{ github.event.release.tag_name || inputs.tag }}" >> $GITHUB_ENV

.github/workflows/qa.yml

@@ -34,18 +34,20 @@ jobs:
           corepack enable
           corepack prepare yarn@stable --activate
 
+      - name: Install dependencies
+        run: yarn
+
       - name: Install Playwright browsers
         run: |
           cd packages/js-sdk
-          npx playwright install --with-deps chromium
+          yarn playwright install --with-deps chromium
 
       - name: Runs the SDK QA checks
         env:
           CONVERT_STAGING_SDK_KEY: ${{ secrets.CONVERT_STAGING_SDK_KEY }}
           CONVERT_STAGING_SDK_KEY2: ${{ secrets.CONVERT_STAGING_SDK_KEY2 }}
           CONVERT_STAGING_SDK_KEY2_SECRET: ${{ secrets.CONVERT_STAGING_SDK_KEY2_SECRET }}
         run: |
-          yarn
           cd packages/js-sdk
           yarn lint
           yarn build

.github/workflows/release-please.yml

@@ -32,7 +32,7 @@ jobs:
       - uses: actions/checkout@v4
       - uses: actions/setup-node@v4
         with:
-          node-version: 18
+          node-version: 22
           registry-url: https://registry.npmjs.org
       - name: Install deps
         run: |

package.json

@@ -49,6 +49,7 @@
     "demo:cloudflare:start": "cd demo/cloudflare-workers && yarn dev"
   },
   "private": true,
+  "packageManager": "yarn@4.10.3+sha512.c38cafb5c7bb273f3926d04e55e1d8c9dfa7d9c3ea1f36a4868fa028b9e5f72298f0b7f401ad5eb921749eb012eb1c3bb74bf7503df3ee43fd600d14a018266f",
   "workspaces": [
     "packages/*",
     "demo/*"

packages/api/package.json

@@ -74,7 +74,7 @@
     "@convertcom/js-sdk-enums": ">=2.3.0",
     "@convertcom/js-sdk-event": ">=2.1.3",
     "@convertcom/js-sdk-logger": ">=2.1.2",
-    "@convertcom/js-sdk-types": ">=3.9.0",
+    "@convertcom/js-sdk-types": ">=3.11.0",
     "@convertcom/js-sdk-utils": ">=2.2.3"
   }
 }

packages/bucketing/package.json

@@ -73,7 +73,7 @@
   "peerDependencies": {
     "@convertcom/js-sdk-enums": ">=2.3.0",
     "@convertcom/js-sdk-logger": ">=2.1.2",
-    "@convertcom/js-sdk-types": ">=3.9.0",
+    "@convertcom/js-sdk-types": ">=3.11.0",
     "@convertcom/js-sdk-utils": ">=2.2.3"
   }
 }

packages/data/package.json

@@ -76,8 +76,8 @@
     "@convertcom/js-sdk-enums": ">=2.3.0",
     "@convertcom/js-sdk-event": ">=2.1.3",
     "@convertcom/js-sdk-logger": ">=2.1.2",
-    "@convertcom/js-sdk-rules": ">=2.1.3",
-    "@convertcom/js-sdk-types": ">=3.9.0",
+    "@convertcom/js-sdk-rules": ">=2.1.4",
+    "@convertcom/js-sdk-types": ">=3.11.0",
     "@convertcom/js-sdk-utils": ">=2.2.3"
   }
 }

packages/event/package.json

@@ -73,6 +73,6 @@
   "peerDependencies": {
     "@convertcom/js-sdk-enums": ">=2.3.0",
     "@convertcom/js-sdk-logger": ">=2.1.2",
-    "@convertcom/js-sdk-types": ">=3.9.0"
+    "@convertcom/js-sdk-types": ">=3.11.0"
   }
 }

packages/experience/package.json

@@ -74,6 +74,6 @@
     "@convertcom/js-sdk-data": ">=3.3.3",
     "@convertcom/js-sdk-enums": ">=2.3.0",
     "@convertcom/js-sdk-logger": ">=2.1.2",
-    "@convertcom/js-sdk-types": ">=3.9.0"
+    "@convertcom/js-sdk-types": ">=3.11.0"
   }
 }

packages/js-sdk/package.json

@@ -94,9 +94,9 @@
     "@convertcom/js-sdk-event": ">=2.1.3",
     "@convertcom/js-sdk-experience": ">=2.3.2",
     "@convertcom/js-sdk-logger": ">=2.1.2",
-    "@convertcom/js-sdk-rules": ">=2.1.3",
+    "@convertcom/js-sdk-rules": ">=2.1.4",
     "@convertcom/js-sdk-segments": ">=2.1.2",
-    "@convertcom/js-sdk-types": ">=3.9.0",
+    "@convertcom/js-sdk-types": ">=3.11.0",
     "@convertcom/js-sdk-utils": ">=2.2.3"
   }
 }

packages/js-sdk/src/context.ts

@@ -136,9 +136,8 @@ export class Context implements ContextInterface {
       this._visitorId,
       experienceKey,
       {
+        ...attributes,
         visitorProperties, // represents audiences
-        locationProperties: attributes?.locationProperties, // represents site_area/locations
-        updateVisitorProperties: attributes?.updateVisitorProperties,
         environment: attributes?.environment || this._environment
       }
     );
@@ -190,9 +189,8 @@ export class Context implements ContextInterface {
     const bucketedVariations = this._experienceManager.selectVariations(
       this._visitorId,
       {
+        ...attributes,
         visitorProperties, // represents audiences
-        locationProperties: attributes?.locationProperties, // represents site_area/locations
-        updateVisitorProperties: attributes?.updateVisitorProperties,
         environment: attributes?.environment || this._environment
       }
     );

packages/js-sdk/tests/context.tests.ts

@@ -179,6 +179,78 @@ describe('Context tests', function () {
         done
       );
     });
+    it('Should forward BucketingAttributes (enableTracking, forceVariationId, ignoreLocationProperties) through runExperience', function () {
+      const experienceKey = 'test-experience-ab-fullstack-2';
+      const originalSelectVariation =
+        experienceManager.selectVariation.bind(experienceManager);
+      let capturedAttributes;
+      experienceManager.selectVariation = function (
+        capturedVisitorId,
+        capturedExperienceKey,
+        attributes
+      ) {
+        capturedAttributes = attributes;
+        return originalSelectVariation(
+          capturedVisitorId,
+          capturedExperienceKey,
+          attributes
+        );
+      };
+      try {
+        context.runExperience(experienceKey, {
+          locationProperties: {url: 'https://convert.com/'},
+          visitorProperties: {varName3: 'something'},
+          enableTracking: false,
+          forceVariationId: '100299461',
+          ignoreLocationProperties: true,
+          updateVisitorProperties: true
+        });
+        expect(capturedAttributes).to.include({
+          enableTracking: false,
+          forceVariationId: '100299461',
+          ignoreLocationProperties: true,
+          updateVisitorProperties: true
+        });
+        expect(capturedAttributes.locationProperties).to.deep.equal({
+          url: 'https://convert.com/'
+        });
+      } finally {
+        experienceManager.selectVariation = originalSelectVariation;
+      }
+    });
+    it('Should forward BucketingAttributes (enableTracking, forceVariationId, ignoreLocationProperties) through runExperiences', function () {
+      const originalSelectVariations =
+        experienceManager.selectVariations.bind(experienceManager);
+      let capturedAttributes;
+      experienceManager.selectVariations = function (
+        capturedVisitorId,
+        attributes
+      ) {
+        capturedAttributes = attributes;
+        return originalSelectVariations(capturedVisitorId, attributes);
+      };
+      try {
+        context.runExperiences({
+          locationProperties: {url: 'https://convert.com/'},
+          visitorProperties: {varName3: 'something'},
+          enableTracking: false,
+          forceVariationId: '100299461',
+          ignoreLocationProperties: true,
+          updateVisitorProperties: true
+        });
+        expect(capturedAttributes).to.include({
+          enableTracking: false,
+          forceVariationId: '100299461',
+          ignoreLocationProperties: true,
+          updateVisitorProperties: true
+        });
+        expect(capturedAttributes.locationProperties).to.deep.equal({
+          url: 'https://convert.com/'
+        });
+      } finally {
+        experienceManager.selectVariations = originalSelectVariations;
+      }
+    });
     it('Shoud successfully get a single feature and its status', function (done) {
       this.timeout(test_timeout);
       getSingleFeatureWithStatus(

packages/rules/package.json

@@ -73,7 +73,7 @@
   "peerDependencies": {
     "@convertcom/js-sdk-enums": ">=2.3.0",
     "@convertcom/js-sdk-logger": ">=2.1.2",
-    "@convertcom/js-sdk-types": ">=3.9.0",
+    "@convertcom/js-sdk-types": ">=3.11.0",
     "@convertcom/js-sdk-utils": ">=2.2.3"
   }
 }

packages/rules/src/rule-manager.ts

@@ -15,6 +15,7 @@ import {RuleManagerInterface} from './interfaces/rule-manager';
 
 import {
   Config,
+  CookieMatchingOptions,
   RuleElement,
   RuleAnd,
   RuleOrWhen,
@@ -165,15 +166,19 @@ export class RuleManager implements RuleManagerInterface {
         rule: rule
       })
     );
-    return (
+    const hasMatching =
       Object.prototype.hasOwnProperty.call(rule, 'matching') &&
       typeof rule.matching === 'object' &&
       Object.prototype.hasOwnProperty.call(rule.matching, 'match_type') &&
       typeof rule.matching.match_type === 'string' &&
       Object.prototype.hasOwnProperty.call(rule.matching, 'negated') &&
-      typeof rule.matching.negated === 'boolean' &&
-      Object.prototype.hasOwnProperty.call(rule, 'value')
-    );
+      typeof rule.matching.negated === 'boolean';
+    if (!hasMatching) return false;
+    const matchType = rule.matching.match_type as string;
+    if (matchType === CookieMatchingOptions.EXISTS || matchType === CookieMatchingOptions.DOES_NOT_EXIST) {
+      return true;
+    }
+    return Object.prototype.hasOwnProperty.call(rule, 'value');
   }
 
   /**
@@ -263,7 +268,7 @@ export class RuleManager implements RuleManagerInterface {
     if (this.isValidRule(rule)) {
       try {
         const negation = rule.matching.negated || false;
-        const matching = rule.matching.match_type;
+        const matching = rule.matching.match_type as string;
         if (this.getComparisonProcessorMethods().indexOf(matching) !== -1) {
           if (data && typeof data === 'object') {
             // Validate data key-value set.
@@ -314,7 +319,19 @@ export class RuleManager implements RuleManagerInterface {
                   );
                 }
               }
-            } else {
+            }
+            // Key not found or data empty — for existence operators, evaluate with undefined
+            if (
+              matching === CookieMatchingOptions.EXISTS ||
+              matching === CookieMatchingOptions.DOES_NOT_EXIST
+            ) {
+              return this._comparisonProcessor[matching](
+                undefined,
+                rule.value,
+                negation
+              );
+            }
+            if (!objectNotEmpty(data) && !this.isUsingCustomInterface(data)) {
               this._loggerManager?.trace?.('RuleManager._processRuleItem()', {
                 warn: ERROR_MESSAGES.RULE_DATA_NOT_VALID,
                 data