-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(headless,bueno): externalize all packages on node outputs #4921
Draft
louis-bompart
wants to merge
13
commits into
master
Choose a base branch
from
node-externals
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+3,464
−5,890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request ReportPR Title✅ Title follows the conventional commit spec. Live demo linksBundle Size
SSR Progress
Detailed logssearch : buildInteractiveResultsearch : buildInteractiveInstantResult search : buildInteractiveRecentResult search : buildInteractiveCitation search : buildGeneratedAnswer recommendation : missing SSR support case-assist : missing SSR support insight : missing SSR support commerce : missing SSR support |
Todo:
Blocked by:
|
69fc00d
to
3cf5292
Compare
fixes #4883
internalize fetch-event-source w/ patch
3450a7f
to
fcd1b08
Compare
5679d50
to
e765ce3
Compare
7cca687
to
ea114e5
Compare
46bf862
to
b46c95f
Compare
b46c95f
to
f2ad5c9
Compare
Bundle size will be broken for this PR because we changed the directory from |
Too big. Needs to be splitted. |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 20, 2025
splits from #4921 Replace [`@microsoft/fetch-event-source`](https://github.com/Azure/fetch-event-source). Essentially a good old copy of the sources, with our patch applied on top and some tweaks in the UT so that they work with Vitest. Includes a copy of the [LICENSE](https://github.com/Azure/fetch-event-source/blob/a0529492576e094374602f24d5e64b3a271b4576/LICENSE).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A couple of changes to allow source maps to work properly for our users, and avoid package duplications in bundles:
Externalize all dependencies for NPM output
Stop bundling on NPM. This was an error, causing duplication of heavy libraries such as Redux on customer websites, reducing their overall performance.
Merge back conditional exports: we don't need those anymore since the bundling we do not pre-bundle anymore
Create a new CDN output that keeps on bundling: Used for our static.cloud.coveo.com shenanigans
Update exponential-backoff (some source map fixes)
Internalize fetch-event sources with its patch (DXUI ownership for the time being): The lib is unmaintained, and its source maps cause issues; the simpler solution is to absorb it.
Stencil sample required stabilization due to its known deficiencies with modern module resolution.
spawnSync
hack.node
, so special resolution for this one --> require NodeJS 22.14.0 formodule.findPackageJSON
fixes #4883