Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use usaco-problems rather than vjudge-usaco for "open in ide" functionality #131

Merged
merged 2 commits into from
Feb 10, 2024

Conversation

xyzqm
Copy link
Member

@xyzqm xyzqm commented Feb 9, 2024

No description provided.

Copy link

vercel bot commented Feb 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ide ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 10, 2024 5:34pm

@xyzqm
Copy link
Member Author

xyzqm commented Feb 9, 2024

@thecodingwizard not sure how to migrate the judging to a serverless function yet, but this should be a good first step :) (if you want to test the functionality, you could try navigating to vercel_path.vercel.app/usaco/1378 or something)

Copy link
Member

@thecodingwizard thecodingwizard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, see comments!

Make sure CI passes before merging though -- in particular, I think you do need to handle invalid problem ID's explicitly.

@xyzqm xyzqm merged commit dc5a97a into master Feb 10, 2024
3 checks passed
@xyzqm xyzqm deleted the vjudge branch February 10, 2024 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants