fix: use numpy reshape instead of keras.ops.reshape in SequenceEstimator#10
Merged
jrosenfeld13 merged 1 commit intomainfrom Jan 24, 2026
Merged
Conversation
Fixes #5 - torch backend LSTMRegressor fit fails with CUDA tensors. The issue was that `ops.reshape()` converts numpy arrays to backend tensors. With torch backend + CUDA GPU, this creates CUDA tensors that `numpy.asarray()` cannot convert back, causing the error: "can't convert cuda:0 device type tensor to numpy" The fix uses numpy's native `reshape()` method instead, keeping data as numpy arrays until `model.fit()` where Keras handles the conversion internally. This matches the pattern used by other estimators (dense.py, autoencoder.py, tree.py) which don't use keras.ops for preprocessing.
This was referenced Jan 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5 - torch backend LSTMRegressor fit fails with CUDA tensors.
The issue was that
ops.reshape()converts numpy arrays to backend tensors. With torch backend + CUDA GPU, this creates CUDA tensors thatnumpy.asarray()cannot convert back, causing the error: "can't convert cuda:0 device type tensor to numpy"The fix uses numpy's native
reshape()method instead, keeping data as numpy arrays untilmodel.fit()where Keras handles the conversion internally. This matches the pattern used by other estimators (dense.py, autoencoder.py, tree.py) which don't use keras.ops for preprocessing.Note
Replaces Keras
ops.reshapewith NumPyreshapeinSequenceEstimatorto keep data as NumPy arrays during preprocessing and avoid unintended backend tensor conversion (e.g., CUDA tensors with Torch backend)._reshapeto callX.reshape(...)and similarly for validation data; return unchanged APIkeras.opsimportmodel.fit()Written by Cursor Bugbot for commit fa223a9. This will update automatically on new commits. Configure here.