chore(security): update packages with critical vulnerabilities in jdk Dockerfile #9977
+40
−62
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
pr:community
…; upgrade OpenJDK to 21 in Dockerfile Update debian base image in jdk Dockerfile
gjav92
force-pushed
the
security/jdk-dockerfile-cve-critical-fix
branch
from
2f2f023 to
f609e02
Compare
KSDaemon
reviewed
Oct 1, 2025
| cp -r /cube/node_modules/lodash /cube/node_modules/jshs2/node_modules/; \ | ||
| fi | ||
|
|
||
| # FIX CVE-2022-41853: Update hsqldb from 2.3.2 to 2.7.1 |
There was a problem hiding this comment.
Why are you trying to fix it here, kind of in the end of the store instead of fixing it in first place? I mean, this should be fixed in https://github.com/cube-js/node-jdbc with the updated versions/references here in cube
|
|
||
| FROM node:22.18.0-bookworm-slim | ||
| && yarn cache clean \ | ||
| # FIX CVE-2019-10744: Patch lodash in unmaintained jshs2 package |
There was a problem hiding this comment.
Is it really needed, as you already provided "jshs2/**/lodash": "4.17.21" in yarn resolutions?
| # python3 package is necessary to install `python3` executable for node-gyp | ||
| # libpython3-dev is needed to trigger post-installer to download native with python | ||
| && apt-get install -y python3 python3.11 libpython3.11-dev gcc g++ make cmake openjdk-17-jdk-headless \ | ||
| && apt-get install -y python3 python3-dev gcc g++ make cmake openjdk-21-jdk-headless wget \ |
There was a problem hiding this comment.
Could you explain the reason for jumping to JDK 21?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses critical security vulnerabilities (CVEs) in the Docker images by:
Changes
Security Fixes
Package-level resolutions (
package.json)[email protected]andform-data@^2.5.4to fix vulnerabilities in transitive dependenciesDocker-specific patches
jshs2package's nested lodash dependencyhive-driverpackageBase image security updates
Critical CVEs Fixed:
Notes
jshs2to the actively maintainedhive-driverpackage, which would require code refactoring.Fixes security vulnerabilities identified in Docker image scans with Trivy.