chore(security): update packages with critical vulnerabilities in jdk Dockerfile #9977
+40
−62
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,5 @@ | ||
| # syntax=docker/dockerfile-upstream:master-experimental | ||
| FROM node:22-trixie-slim AS builder | ||
|
|
||
| WORKDIR /cube | ||
| COPY . . | ||
|
|
@@ -12,17 +12,33 @@ RUN yarn config set network-timeout 120000 -g | |
| RUN apt-get update \ | ||
| # python3 package is necessary to install `python3` executable for node-gyp | ||
| # libpython3-dev is needed to trigger post-installer to download native with python | ||
| && apt-get install -y python3 python3-dev gcc g++ make cmake openjdk-21-jdk-headless wget \ | ||
| && rm -rf /var/lib/apt/lists/* | ||
|
|
||
| # We are copying root yarn.lock file to the context folder during the Publish GH | ||
| # action. So, a process will use the root lock file here. | ||
| RUN yarn install --prod \ | ||
| # Remove DuckDB sources to reduce image size | ||
| && rm -rf /cube/node_modules/duckdb/src \ | ||
| && yarn cache clean \ | ||
| # FIX CVE-2019-10744: Patch lodash in unmaintained jshs2 package | ||
|
There was a problem hiding this comment. Is it really needed, as you already provided |
||
| # jshs2 hasn't been updated since 2017 and bundles lodash 3.10.1 with critical vulnerabilities | ||
| # This is a temporary fix until migration to hive-driver is completed | ||
| && if [ -d /cube/node_modules/jshs2/node_modules/lodash ]; then \ | ||
| echo "Patching lodash in jshs2 from 3.10.1 to 4.17.21 (CVE-2019-10744 fix)" && \ | ||
| rm -rf /cube/node_modules/jshs2/node_modules/lodash && \ | ||
| cp -r /cube/node_modules/lodash /cube/node_modules/jshs2/node_modules/; \ | ||
| fi | ||
|
|
||
| # FIX CVE-2022-41853: Update hsqldb from 2.3.2 to 2.7.1 | ||
|
There was a problem hiding this comment. Why are you trying to fix it here, kind of in the end of the store instead of fixing it in first place? I mean, this should be fixed in https://github.com/cube-js/node-jdbc with the updated versions/references here in cube |
||
| # Note: This is a JAR file that cannot be fixed via npm/yarn resolutions | ||
| RUN wget -O /tmp/hsqldb-2.7.1.jar https://repo1.maven.org/maven2/org/hsqldb/hsqldb/2.7.1/hsqldb-2.7.1.jar \ | ||
| && if [ -f /cube/node_modules/@cubejs-backend/jdbc/drivers-10.17/hsqldb.jar ]; then \ | ||
| mv /tmp/hsqldb-2.7.1.jar /cube/node_modules/@cubejs-backend/jdbc/drivers-10.17/hsqldb.jar; \ | ||
| fi \ | ||
| && rm -f /tmp/hsqldb-2.7.1.jar | ||
|
|
||
| FROM node:22-trixie-slim | ||
|
|
||
| ARG IMAGE_VERSION=unknown | ||
|
|
||
|
|
@@ -32,7 +48,7 @@ ENV CUBEJS_DOCKER_IMAGE_TAG=latest | |
| RUN groupadd cube && useradd -ms /bin/bash -g cube cube \ | ||
| && DEBIAN_FRONTEND=noninteractive \ | ||
| && apt-get update \ | ||
| && apt-get install -y --no-install-recommends libssl3 openjdk-21-jre-headless python3 python3-dev \ | ||
| && rm -rf /var/lib/apt/lists/* \ | ||
| && mkdir cube \ | ||
| && chown -R cube:cube /tmp /cube /usr | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -11744,7 +11744,7 @@ [email protected]: | |
| strip-ansi "^6.0.1" | ||
| wcwidth "^1.0.0" | ||
|
|
||
| combined-stream@^1.0.8, combined-stream@~1.0.6: | ||
| version "1.0.8" | ||
| resolved "https://registry.yarnpkg.com/combined-stream/-/combined-stream-1.0.8.tgz#c3d45a8b34fd730631a110a8a2520682b31d5a7f" | ||
| integrity sha512-FQN4MRfuJeHf7cBbBMJFXhKSDq+2kAArBlmRBvcvFE5BB1HZKXtSFASDhdlz9zOYwxh8lDdnvmMOe/+5cdoEdg== | ||
|
|
@@ -14942,34 +14942,17 @@ forever-agent@~0.6.1: | |
| resolved "https://registry.yarnpkg.com/forever-agent/-/forever-agent-0.6.1.tgz#fbc71f0c41adeb37f96c577ad1ed42d8fdacca91" | ||
| integrity sha1-+8cfDEGt6zf5bFd60e1C2P2sypE= | ||
|
|
||
| form-data@^2.3.1, form-data@^2.5.0, form-data@^2.5.4, form-data@^3.0.0, form-data@^4.0.0, form-data@^4.0.4, form-data@~4.0.0: | ||
| version "2.5.5" | ||
| resolved "https://registry.yarnpkg.com/form-data/-/form-data-2.5.5.tgz#a5f6364ad7e4e67e95b4a07e2d8c6f711c74f624" | ||
| integrity sha512-jqdObeR2rxZZbPSGL+3VckHMYtu+f9//KXBsVny6JSX/pa38Fy+bGjuG8eW/H6USNQWhLi8Num++cU2yOCNz4A== | ||
| dependencies: | ||
| asynckit "^0.4.0" | ||
| combined-stream "^1.0.8" | ||
| es-set-tostringtag "^2.1.0" | ||
| hasown "^2.0.2" | ||
| mime-types "^2.1.35" | ||
| safe-buffer "^5.2.1" | ||
|
|
||
| formdata-polyfill@^4.0.10: | ||
| version "4.0.10" | ||
|
|
@@ -18764,7 +18747,7 @@ lodash.upperfirst@^4.3.1: | |
| resolved "https://registry.yarnpkg.com/lodash.upperfirst/-/lodash.upperfirst-4.3.1.tgz#1365edf431480481ef0d1c68957a5ed99d49f7ce" | ||
| integrity sha1-E2Xt9DFIBIHvDRxolXpe2Z1J984= | ||
|
|
||
| lodash@4.17.21, lodash@^3.10.1, lodash@^4.16.5, lodash@^4.17.11, lodash@^4.17.13, lodash@^4.17.14, lodash@^4.17.15, lodash@^4.17.19, lodash@^4.17.20, lodash@^4.17.21, lodash@^4.17.4, lodash@^4.7.0: | ||
| version "4.17.21" | ||
| resolved "https://registry.yarnpkg.com/lodash/-/lodash-4.17.21.tgz#679591c564c3bffaae8454cf0b3df370c3d6911c" | ||
| integrity sha512-v2kDEe57lecTulaDIuNTPy3Ry4gLGJ6Z1O3vE1krgXZNrsQ+LFTGHVxVjcXPs17LhbZVGedAJv8XZ1tvj5FvSg== | ||
|
|
@@ -19185,7 +19168,7 @@ [email protected], "mime-db@>= 1.43.0 < 2": | |
| resolved "https://registry.yarnpkg.com/mime-db/-/mime-db-1.52.0.tgz#bbabcdc02859f4987301c856e3387ce5ec43bf70" | ||
| integrity sha512-sPU4uV7dYlvtWJxwwxHD0PuihVNiE7TyAbQ5SWxDCB9mUYvOgroQOwYQQOKPJ8CIbE+1ETVlOoK1UC2nU3gYvg== | ||
|
|
||
| mime-types@^2.1.27, mime-types@^2.1.29, mime-types@^2.1.31, mime-types@^2.1.35, mime-types@~2.1.17, mime-types@~2.1.19, mime-types@~2.1.24, mime-types@~2.1.34: | ||
| version "2.1.35" | ||
| resolved "https://registry.yarnpkg.com/mime-types/-/mime-types-2.1.35.tgz#381a871b62a734450660ae3deee44813f70d959a" | ||
| integrity sha512-ZDY+bPm5zTTF+YpCrAU9nK0UgICYPT0QtT1NZWFv4s++TNkcgVaT0g6+4R2uI4MjQjzysHB1zxuWL50hzaeXiw== | ||
|
|
@@ -23158,7 +23141,7 @@ [email protected], safe-buffer@~5.1.0, safe-buffer@~5.1.1: | |
| resolved "https://registry.yarnpkg.com/safe-buffer/-/safe-buffer-5.1.2.tgz#991ec69d296e0313747d59bdfd2b745c35f8828d" | ||
| integrity sha512-Gd2UZBJDkXlY7GbJxfsE8/nvKkUEU1G38c1siN6QP6a9PT9MmHB8GnpscSmMJSoF8LOIrt8ud/wPtojys4G6+g== | ||
|
|
||
| [email protected], safe-buffer@>=5.1.0, safe-buffer@^5.0.1, safe-buffer@^5.1.0, safe-buffer@^5.1.1, safe-buffer@^5.1.2, safe-buffer@^5.2.1, safe-buffer@~5.2.0: | ||
| version "5.2.1" | ||
| resolved "https://registry.yarnpkg.com/safe-buffer/-/safe-buffer-5.2.1.tgz#1eaf9fa9bdb1fdd4ec75f58f9cdb4e6b7827eec6" | ||
| integrity sha512-rp3So07KcdmmKbGvgaNxQSJr7bGVSVk5S9Eq1F+ppbRo70+YeaDxkw5Dd8NPN+GD6bjnYm2VuPuCXmpuYvmCXQ== | ||
|
|
@@ -24165,16 +24148,7 @@ string-length@^5.0.1: | |
| char-regex "^2.0.0" | ||
| strip-ansi "^7.0.1" | ||
|
|
||
| "string-width-cjs@npm:string-width@^4.2.0", "string-width@^1.0.2 || 2 || 3 || 4", string-width@^4.0.0, string-width@^4.1.0, string-width@^4.2.0, string-width@^4.2.3: | ||
| version "4.2.3" | ||
| resolved "https://registry.yarnpkg.com/string-width/-/string-width-4.2.3.tgz#269c7117d27b05ad2e536830a8ec895ef9c6d010" | ||
| integrity sha512-wKyQRQpjJ0sIp62ErSZdGsjMJWsap5oRNihHhu6G7JVO/9jIB6UyevL+tXuOqrng8j/cxKTWyWUwvSTriiZz/g== | ||
|
|
@@ -24265,7 +24239,7 @@ string_decoder@~1.1.1: | |
| dependencies: | ||
| safe-buffer "~5.1.0" | ||
|
|
||
| "strip-ansi-cjs@npm:strip-ansi@^6.0.1", strip-ansi@^6.0.0, strip-ansi@^6.0.1: | ||
| version "6.0.1" | ||
| resolved "https://registry.yarnpkg.com/strip-ansi/-/strip-ansi-6.0.1.tgz#9e26c63d30f53443e9489495b2105d37b67a85d9" | ||
| integrity sha512-Y38VPSHcqkFrCpFnQ9vuSXmquuv5oXOKpGeT6aGrr3o3Gc9AlVa6JBfUSOCnbxGGZF+/0ooI7KrPuUSztUdU5A== | ||
|
|
@@ -24293,13 +24267,6 @@ strip-ansi@^5.2.0: | |
| dependencies: | ||
| ansi-regex "^4.1.0" | ||
|
|
||
| strip-ansi@^7.0.1, strip-ansi@^7.1.0: | ||
| version "7.1.0" | ||
| resolved "https://registry.yarnpkg.com/strip-ansi/-/strip-ansi-7.1.0.tgz#d5b6568ca689d8561370b0707685d22434faff45" | ||
|
|
@@ -26381,7 +26348,7 @@ workerpool@^9.2.0: | |
| resolved "https://registry.yarnpkg.com/workerpool/-/workerpool-9.2.0.tgz#f74427cbb61234708332ed8ab9cbf56dcb1c4371" | ||
| integrity sha512-PKZqBOCo6CYkVOwAxWxQaSF2Fvb5Iv2fCeTP7buyWI2GiynWr46NcXSgK/idoV6e60dgCBfgYc+Un3HMvmqP8w== | ||
|
|
||
| "wrap-ansi-cjs@npm:wrap-ansi@^7.0.0", wrap-ansi@^7.0.0: | ||
| version "7.0.0" | ||
| resolved "https://registry.yarnpkg.com/wrap-ansi/-/wrap-ansi-7.0.0.tgz#67e145cff510a6a6984bdf1152911d69d2eb9e43" | ||
| integrity sha512-YVGIj2kamLSTxw6NsZjoBxfSwsn0ycdesmc4p+Q21c5zPuZ1pl+NfxVdxPtdHvmNVOQ6XSYG4AUtyt/Fi7D16Q== | ||
|
|
@@ -26407,15 +26374,6 @@ wrap-ansi@^6.0.1, wrap-ansi@^6.2.0: | |
| string-width "^4.1.0" | ||
| strip-ansi "^6.0.0" | ||
|
|
||
| wrap-ansi@^8.1.0: | ||
| version "8.1.0" | ||
| resolved "https://registry.yarnpkg.com/wrap-ansi/-/wrap-ansi-8.1.0.tgz#56dc22368ee570face1b49819975d9b9a5ead214" | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you explain the reason for jumping to JDK 21?