Migrate rust scope implementations #2950
Conversation
|
@pokey Here is another one that is questionable. Type arguments as |
| @@ -2,6 +2,6 @@ | |||
| * The language IDs that we have full tree-sitter support for using our legacy | |||
| * modifiers. | |||
| */ | |||
| export const legacyLanguageIds = ["rust"] as const; | |||
| export const legacyLanguageIds = ["dummy"] as const; | |||
There was a problem hiding this comment.
Compilation error if this list is empty. Cleaning up all the legacy machinery will be done in a follow up.
| action: | ||
| name: clearAndSetSelection | ||
| target: | ||
| type: primitive | ||
| modifiers: | ||
| - type: containingScope | ||
| scopeType: {type: name} | ||
| scopeType: {type: collectionKey} |
There was a problem hiding this comment.
This looks more like a key / value map than call arguments
There was a problem hiding this comment.
In no other language is the domain for the return value the entire function. This is also extra problematic since you can have multiple return statements.
| @@ -13,6 +13,9 @@ command: | |||
| scopeType: {type: argumentOrParameter} | |||
There was a problem hiding this comment.
Should this also be a type? (How do we handle tuple types in TypeScript?)
There was a problem hiding this comment.
Which one?
You mean typed arrays like [number, string]? Those are just collection items and not usable as type.
No description provided.