-
-
Notifications
You must be signed in to change notification settings - Fork 85
Migrate rust scope implementations #2950
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
bb9cdec
9fc0822
b8b4014
93d7501
833cbff
979a7cc
56c33f7
834c7aa
a48730d
89cc422
ade9890
365a27c
87b7f3c
396d762
887d62a
67bbbdd
999d164
c4d1ce2
5778f19
3786be2
3cdf1d6
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,14 +1,14 @@ | ||
languageId: rust | ||
command: | ||
version: 6 | ||
spokenForm: change name drum | ||
spokenForm: change key drum | ||
action: | ||
name: clearAndSetSelection | ||
target: | ||
type: primitive | ||
modifiers: | ||
- type: containingScope | ||
scopeType: {type: name} | ||
scopeType: {type: collectionKey} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This looks more like a key / value map than call arguments |
||
mark: {type: decoratedSymbol, symbolColor: default, character: d} | ||
usePrePhraseSnapshot: true | ||
initialState: | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. In no other language is the domain for the return value the entire function. This is also extra problematic since you can have multiple return statements. |
This file was deleted.
This file was deleted.
This file was deleted.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this also be a type? (How do we handle tuple types in TypeScript?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Which one?
You mean typed arrays like
[number, string]
? Those are just collection items and not usable astype
.