runDangerSubprocess implementation is incorrect (?)

[miklosme]

I encountered an issue, when danger fails on the validateResults function (DangerResults.ts) although the result is actually correct. It throws Results passed to Danger JS did not include fails. The result argument passed here is indeed an empty object, however the result has a correct shape at an earlier point, as it's printed to the console.

I noticed this only happens if I include markdown to the result, and only if the markdown is bigger than a certain size. This makes me think the subprocess stream is not correctly read here: https://github.com/danger/danger-js/blob/master/source/commands/utils/runDangerSubprocess.ts#L38

Because this code assumes the data will arrive in a single chunk (L43), and if it's not a json string (L41), it won't process the data ever.

Am I thinking right?

[orta]

That could make sense yeah 👍

[orta]

I just triggered this when I started adding console.logs into the output of my dangerfile

[fbartho]

I'm also exhibiting this issue, I think because a lot of errors were emitted so the json got big.

[orta]

This should be fixed in the latest builds of Danger JS (it came in with all of the GitHub actions support in #697 )

[fbartho]

Oh great! -- Upgrading Presently!