Repository navigation
Read Arrow rows directly from vectors with per-batch converters - #628
Merged
Merged
Conversation
Signed-off-by: Vu Anh Phung <vu.phung@databricks.com> Co-authored-by: Isaac <no-reply@databricks.com>
vuanhphung
temporarily deployed
to
azure-prod
November 19, 2026 07:28 — with
GitHub Actions
Inactive
vuanhphung
temporarily deployed
to
azure-prod
November 19, 2026 07:28 — with
GitHub Actions
Inactive
vuanhphung
temporarily deployed
to
azure-prod
November 19, 2026 07:28 — with
GitHub Actions
Inactive
Signed-off-by: Vu Anh Phung <vu.phung@databricks.com> Co-authored-by: Isaac <no-reply@databricks.com>
vuanhphung
temporarily deployed
to
azure-prod
November 19, 2026 07:40 — with
GitHub Actions
Inactive
vuanhphung
temporarily deployed
to
azure-prod
November 19, 2026 07:40 — with
GitHub Actions
Inactive
vuanhphung
temporarily deployed
to
azure-prod
November 19, 2026 07:40 — with
GitHub Actions
Inactive
Signed-off-by: Vu Anh Phung <vu.phung@databricks.com> Co-authored-by: Isaac <no-reply@databricks.com>
vuanhphung
temporarily deployed
to
azure-prod
November 19, 2026 09:25 — with
GitHub Actions
Inactive
vuanhphung
temporarily deployed
to
azure-prod
November 19, 2026 09:25 — with
GitHub Actions
Inactive
vuanhphung
temporarily deployed
to
azure-prod
November 19, 2026 09:25 — with
GitHub Actions
Inactive
vuanhphung
marked this pull request as ready for review
November 19, 2026 09:25
Signed-off-by: Vu Anh Phung <vu.phung@databricks.com> Co-authored-by: Isaac <no-reply@databricks.com>
vuanhphung
temporarily deployed
to
azure-prod
November 19, 2026 17:14 — with
GitHub Actions
Inactive
vuanhphung
temporarily deployed
to
azure-prod
November 19, 2026 17:14 — with
GitHub Actions
Inactive
vuanhphung
temporarily deployed
to
azure-prod
November 19, 2026 17:14 — with
GitHub Actions
Inactive
aakash-saravanan-db
approved these changes
Nov 19, 2026
aakash-saravanan-db
left a comment
Collaborator
There was a problem hiding this comment.
LGTM. Resolving converters once per record batch and reading vectors directly removes the repeated per-cell work at the right boundary. The guarded fallback and regression coverage give good confidence that existing result semantics are preserved.
Non-blocking test suggestion: could we extend the parity tests with nested and dictionary-encoded BIGINT/DECIMAL values under preserveBigNumericPrecision: true, including nulls and values beyond the safe integer range, and compare against the legacy conversion path? Top-level precision coverage is strong; these combinations would further protect future converter changes.
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Arrow object materialization spends most CPU repeatedly dispatching types and expanding StructRow proxies: a decoded-batch profile attributes 76% of sampled time to the recursive converter. Both Thrift and kernel results use this path.
Read top-level vectors directly into final rows and resolve scalar converters once per batch. Keep nested conversion and the legacy object path for duplicate/special names unchanged. Values, precision options, logging, disabled materialization and IPC/fetching behavior stay the same.
Verification: 1,831 unit tests pass (agent markers cleared; the unrelated default-environment user-agent failure also reproduces on main), all static checks pass, and 47 live e2e cases plus type/limit/lifecycle checksum matrices pass. Fresh-process live medians below use five interleaved pairs on Node 24; p95/p99 and raw runs are in the factory handoff. Decoded DOUBLE/object CPU: 480 → 45 ms/million rows. Array-mode heap peaks can increase with GC slack; bounded-heap runs still complete.
Follow-up verification: fallback tests now reject both guard-removal mutants cleanly; all 1,831 units and static checks pass, and the shared Thrift/kernel row-materialization specs each pass 8 live cases with no skips; kernel CI now detects shared result changes.
Adversarial review: converged in round 1; gains and parity independently reproduced, fallback/precision/binary tests strengthened and mutation-checked, array-mode memory caveat documented.
This pull request and its description were written by Isaac.