-
Notifications
You must be signed in to change notification settings - Fork 81
Implement databricks creds manager #2123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
✅ 51/51 passed, 6 flaky, 3m43s total Flaky tests:
Running from acceptance #3273 |
# Conflicts: # src/databricks/labs/lakebridge/reconcile/connectors/jdbc_reader.py # src/databricks/labs/lakebridge/reconcile/connectors/oracle.py
…e plus major cleanup
… in one test for it to be green
|
The goal of the dict is to contain the connection properties, for example: {
"user": "scope/key",
"password": "scope/key2",
"host": "scope3/key4",
"port": "scope4/key5",
"database": "scope/key3",
"encrypt": "scope/key",
"trustServerCertificate": "scope/key"
}i.e. mapping logical connection options to In other words, my intent in this PR was always to model the connection properties / OPTIONS(...) side (N) and how they reference secrets, not to introduce a general vault configuration model. The stacked PRs already use this dict in the connection resolution path; the vault backend shape (M) can still be tightened separately if we want. |
…#2159) <!-- REMOVE IRRELEVANT COMMENTS BEFORE CREATING A PULL REQUEST --> ## Changes <!-- Summary of your changes that are easy to understand. Add screenshots when necessary, they're helpful to illustrate the before and after state --> ### What does this PR do? * Move away from hardcoded secrets in reconcile * use credential manager which enables local, env and databricks ### Relevant implementation details * add `load_credentials` to `DataSource` which takes care of loading the credentials ### Caveats/things to watch out for when reviewing: ### Linked issues <!-- DOC: Link issue with a keyword: close, closes, closed, fix, fixes, fixed, resolve, resolves, resolved. See https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword --> Progresses #1008, #2123, #2157 ### Functionality - [ ] added relevant user documentation - [ ] added new CLI command - [X] modified existing command: `databricks labs lakebridge reconcile` - [ ] ... +add your own ### Tests <!-- How is this tested? Please see the checklist below and also describe any other relevant tests --> - [ ] manually tested - [X] added unit tests - [X] added integration tests --------- Co-authored-by: Guenia Izquierdo <[email protected]>
# Conflicts: # src/databricks/labs/lakebridge/reconcile/connectors/source_adapter.py
Changes
What does this PR do?
Linked issues
Progresses #1008
Functionality
databricks labs lakebridge ...Tests