prompt for recon secrets #2157
Open
prompt for recon secrets #2157
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-abulazm
added
feat/cli
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## refactor/creds-manager #2157 +/- ##
==========================================================
- Coverage 64.30% 64.07% -0.24%
==========================================================
Files 100 100
Lines 8747 8696 -51
Branches 918 915 -3
==========================================================
- Hits 5625 5572 -53
- Misses 2947 2948 +1
- Partials 175 176 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
✅ 51/51 passed, 6 flaky, 4m14s total Flaky tests:
Running from acceptance #3275 |
7 tasks
# Conflicts: # src/databricks/labs/lakebridge/install.py # tests/unit/test_install.py
sundarshankar89
requested changes
Dec 5, 2025
| ``` | ||
| If not set the default values will be used to store the metadata. The default resources are created during the installation | ||
| of Lakebridge. | ||
| - `creds_or_secret_scope`: The credentials to use to connect to the data source. Made optional for backwards compatibility. |
Collaborator
There was a problem hiding this comment.
Do we want to give this flexibility ?
I would rather force them to use secret scope for reconcile do not open up.
if this is required for testing then we can explore other options.
Contributor
Author
There was a problem hiding this comment.
changed back to secret scope
# Conflicts: # src/databricks/labs/lakebridge/install.py # src/databricks/labs/lakebridge/reconcile/trigger_recon_service.py # tests/integration/reconcile/query_builder/test_execute.py # tests/integration/reconcile/test_oracle_reconcile.py # tests/unit/deployment/test_installation.py # tests/unit/deployment/test_job.py # tests/unit/deployment/test_recon.py # tests/unit/test_install.py
m-abulazm
added a commit
that referenced
this pull request
Dec 22, 2025
…#2159) <!-- REMOVE IRRELEVANT COMMENTS BEFORE CREATING A PULL REQUEST --> ## Changes <!-- Summary of your changes that are easy to understand. Add screenshots when necessary, they're helpful to illustrate the before and after state --> ### What does this PR do? * Move away from hardcoded secrets in reconcile * use credential manager which enables local, env and databricks ### Relevant implementation details * add `load_credentials` to `DataSource` which takes care of loading the credentials ### Caveats/things to watch out for when reviewing: ### Linked issues <!-- DOC: Link issue with a keyword: close, closes, closed, fix, fixes, fixed, resolve, resolves, resolved. See https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword --> Progresses #1008, #2123, #2157 ### Functionality - [ ] added relevant user documentation - [ ] added new CLI command - [X] modified existing command: `databricks labs lakebridge reconcile` - [ ] ... +add your own ### Tests <!-- How is this tested? Please see the checklist below and also describe any other relevant tests --> - [ ] manually tested - [X] added unit tests - [X] added integration tests --------- Co-authored-by: Guenia Izquierdo <[email protected]>
# Conflicts: # src/databricks/labs/lakebridge/install.py # tests/unit/test_install.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
What does this PR do?
Add prompts during
configure-reconcilefor the data sources' credentials. this allows users to use local, env or databricks secrets.this is more flexible and secure than the current approach that requires users to create a secret specifically for reconcile and now users can reuse their existing secrets.
Also allows reconcile to support new vault types e.g. azure, google secrets as we implement more supported backends in the future
Linked issues
Progresses #1008, #2123, #2159
Functionality
databricks labs lakebridge configure-reconcileTests