-
Notifications
You must be signed in to change notification settings - Fork 81
Use configurable credentials in reconcile in place of db secret scope #2159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
m-abulazm
merged 15 commits into
refactor/creds-manager
from
refactor/reconcile-creds-2
Dec 22, 2025
Merged
Use configurable credentials in reconcile in place of db secret scope #2159
m-abulazm
merged 15 commits into
refactor/creds-manager
from
refactor/reconcile-creds-2
Dec 22, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fbce1c6 to
e606c7e
Compare
e606c7e to
bf928ff
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## refactor/creds-manager #2159 +/- ##
==========================================================
- Coverage 63.68% 63.53% -0.16%
==========================================================
Files 100 98 -2
Lines 8542 8561 +19
Branches 886 895 +9
==========================================================
- Hits 5440 5439 -1
- Misses 2935 2950 +15
- Partials 167 172 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
✅ 51/51 passed, 4 flaky, 4m46s total Flaky tests:
Running from acceptance #3224 |
# Conflicts: # src/databricks/labs/lakebridge/reconcile/trigger_recon_service.py
5 tasks
# Conflicts: # src/databricks/labs/lakebridge/reconcile/connectors/oracle.py # src/databricks/labs/lakebridge/reconcile/connectors/tsql.py # tests/unit/reconcile/connectors/test_oracle.py # tests/unit/reconcile/connectors/test_sql_server.py
# Conflicts: # src/databricks/labs/lakebridge/reconcile/trigger_recon_service.py
# Conflicts: # tests/conftest.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
New feature or request
feat/recon
making sure that remorphed query produces the same results as original
stacked PR
Should be reviewed, but not merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
What does this PR do?
Relevant implementation details
load_credentialstoDataSourcewhich takes care of loading the credentialsCaveats/things to watch out for when reviewing:
Linked issues
Progresses #1008, #2123, #2157
Functionality
databricks labs lakebridge reconcileTests