feat(ingestion/hex): Allow category filters #16752
+395
−13
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| import json | ||
| import os | ||
| from pathlib import Path | ||
|
|
||
|
|
||
| def load_json_data(filename): | ||
| """Load test data from JSON files in the test_data directory.""" | ||
| test_dir = Path(os.path.dirname(os.path.abspath(__file__))) | ||
| file_path = test_dir / "test_data" / filename | ||
| with open(file_path, "r") as f: | ||
| return json.load(f) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,212 @@ | ||
| { | ||
| "values": [ | ||
| { | ||
| "id": "d73da67d-c87b-4dd8-9e7f-b79cb7f822cg", | ||
| "title": "PlayNotebook", | ||
| "description": "This is a play project\n\n", | ||
| "type": "PROJECT", | ||
| "creator": { | ||
| "email": "user5@example.com" | ||
| }, | ||
| "owner": { | ||
| "email": "user5@example.com" | ||
| }, | ||
| "status": { | ||
| "name": "In development" | ||
| }, | ||
| "categories": [ | ||
| { | ||
| "name": "Scratchpad", | ||
| "description": "Personal scratchpad for a team member. Not intended for broad consumption" | ||
| } | ||
| ], | ||
| "reviews": { | ||
| "required": false | ||
| }, | ||
| "analytics": { | ||
| "appViews": { | ||
| "allTime": 16, | ||
| "lastSevenDays": 1, | ||
| "lastFourteenDays": 1, | ||
| "lastThirtyDays": 1 | ||
| }, | ||
| "lastViewedAt": "2025-03-17T14:55:34.717Z", | ||
| "publishedResultsUpdatedAt": "2025-03-18T12:11:34.907Z" | ||
| }, | ||
| "lastEditedAt": "2024-12-18T08:38:03.873Z", | ||
| "lastPublishedAt": "2024-12-13T23:26:27.466Z", | ||
| "createdAt": "2024-12-03T09:54:58.471Z", | ||
| "archivedAt": null, | ||
| "trashedAt": null, | ||
| "schedules": [ | ||
| { | ||
| "cadence": "WEEKLY", | ||
| "enabled": true, | ||
| "hourly": null, | ||
| "daily": null, | ||
| "weekly": { | ||
| "dayOfWeek": "TUESDAY", | ||
| "hour": 17, | ||
| "minute": 40, | ||
| "timezone": "+05:30" | ||
| }, | ||
| "monthly": null, | ||
| "custom": null | ||
| } | ||
| ], | ||
| "sharing": { | ||
| "users": [ | ||
| { | ||
| "user": { | ||
| "email": "user4a@example.com" | ||
| }, | ||
| "access": "FULL_ACCESS" | ||
| }, | ||
| { | ||
| "user": { | ||
| "email": "user5@example.com" | ||
| }, | ||
| "access": "FULL_ACCESS" | ||
| } | ||
| ], | ||
| "collections": [], | ||
| "groups": [], | ||
| "workspace": { | ||
| "access": "NONE" | ||
| }, | ||
| "publicWeb": { | ||
| "access": "NONE" | ||
| }, | ||
| "support": { | ||
| "access": "NONE" | ||
| } | ||
| } | ||
| }, | ||
| { | ||
| "id": "e8d7c5a3-2b4f-4e21-9823-1a3b5c7d9e0f", | ||
| "title": "Mixed Categories Project", | ||
| "description": "Project with both Scratchpad and Keep_Scratchpad categories", | ||
| "type": "PROJECT", | ||
| "creator": { | ||
| "email": "user6@example.com" | ||
| }, | ||
| "owner": { | ||
| "email": "user6@example.com" | ||
| }, | ||
| "status": { | ||
| "name": "Published" | ||
| }, | ||
| "categories": [ | ||
| { | ||
| "name": "Scratchpad", | ||
| "description": "Personal scratchpad for a team member. Not intended for broad consumption" | ||
| }, | ||
| { | ||
| "name": "Keep_Scratchpad", | ||
| "description": "Intended for broad consumption" | ||
| } | ||
| ], | ||
| "reviews": { | ||
| "required": false | ||
| }, | ||
| "analytics": { | ||
| "appViews": { | ||
| "allTime": 25, | ||
| "lastSevenDays": 5, | ||
| "lastFourteenDays": 10, | ||
| "lastThirtyDays": 20 | ||
| }, | ||
| "lastViewedAt": "2025-03-20T10:30:00.000Z", | ||
| "publishedResultsUpdatedAt": "2025-03-21T12:00:00.000Z" | ||
| }, | ||
| "lastEditedAt": "2024-12-20T14:30:00.000Z", | ||
| "lastPublishedAt": "2024-12-15T09:00:00.000Z", | ||
| "createdAt": "2024-12-05T11:00:00.000Z", | ||
| "archivedAt": null, | ||
| "trashedAt": null, | ||
| "schedules": [], | ||
| "sharing": { | ||
| "users": [ | ||
| { | ||
| "user": { | ||
| "email": "user6@example.com" | ||
| }, | ||
| "access": "FULL_ACCESS" | ||
| } | ||
| ], | ||
| "collections": [], | ||
| "groups": [], | ||
| "workspace": { | ||
| "access": "NONE" | ||
| }, | ||
| "publicWeb": { | ||
| "access": "NONE" | ||
| }, | ||
| "support": { | ||
| "access": "NONE" | ||
| } | ||
| } | ||
| }, | ||
| { | ||
| "id": "4759f33c-1ab9-403d-92e8-9bef48de00cg", | ||
| "title": "Cancelled Orders", | ||
| "description": null, | ||
| "type": "COMPONENT", | ||
| "creator": { | ||
| "email": "user4a@example.com" | ||
| }, | ||
| "owner": { | ||
| "email": "user4a@example.com" | ||
| }, | ||
| "status": null, | ||
| "categories": [{ | ||
| "name": "Keep_Scratchpad", | ||
| "description": "Intended for broad consumption" | ||
| }], | ||
|
Contributor
There was a problem hiding this comment. Please add more test cases with mix of allowed and denied categories for more rigorous testing. |
||
| "reviews": { | ||
| "required": false | ||
| }, | ||
| "analytics": { | ||
| "appViews": { | ||
| "allTime": 0, | ||
| "lastSevenDays": 0, | ||
| "lastFourteenDays": 0, | ||
| "lastThirtyDays": 0 | ||
| }, | ||
| "lastViewedAt": null, | ||
| "publishedResultsUpdatedAt": "2024-12-13T23:22:48.995Z" | ||
| }, | ||
| "lastEditedAt": "2024-12-13T23:22:58.183Z", | ||
| "lastPublishedAt": "2024-12-13T23:22:58.189Z", | ||
| "createdAt": "2024-12-09T15:39:26.093Z", | ||
| "archivedAt": null, | ||
| "trashedAt": null, | ||
| "schedules": [], | ||
| "sharing": { | ||
| "users": [ | ||
| { | ||
| "user": { | ||
| "email": "user4a@example.com" | ||
| }, | ||
| "access": "FULL_ACCESS" | ||
| } | ||
| ], | ||
| "collections": [], | ||
| "groups": [], | ||
| "workspace": { | ||
| "access": "NONE" | ||
| }, | ||
| "publicWeb": { | ||
| "access": "NONE" | ||
| }, | ||
| "support": { | ||
| "access": "NONE" | ||
| } | ||
| } | ||
| } | ||
| ], | ||
| "pagination": { | ||
| "after": "djI6WyIyMDI0LTEyLTA5VDE1OjM5OjI2LjA5M1oiLCI0NzU5ZjMzYy0xYWI5LTQwM2QtOTJlOC05YmVmNDhkZTAwYzQiXQ", | ||
| "before": "djI6WyIyMDI0LTA4LTIxVDE3OjA3OjE5LjI3NVoiLCJjOGY4MTVjOC04OGMyLTRkZWEtOTgxZi02OWY1NDRkNjE2NWQiXQ" | ||
| } | ||
| } | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alokr-dhub where would you suggest putting this logic in terms of a new function? I ask because having it here pattern matches lines 270 and 278, so I didn't find a natural place to put the function.
i could add it to the HexAPI class if you think that's a good spot for it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok. we can keep it here now. ideally all the checks should be in a separate internal method in the hex source class