Skip to content

fix: Revert "fix(ingest/mssql): lowercase field paths when convert_urns_to_lowercase=True (#16736)"#16770

Merged
ligfx merged 1 commit intomasterfrom
mm--revert-mssql-lowercase-columns
Mar 25, 2026
Merged

fix: Revert "fix(ingest/mssql): lowercase field paths when convert_urns_to_lowercase=True (#16736)"#16770
ligfx merged 1 commit intomasterfrom
mm--revert-mssql-lowercase-columns

Conversation

@ligfx
Copy link
Contributor

@ligfx ligfx commented Mar 25, 2026

Reverts #16736, which breaks pre-existing column documentation and tags/terms/structured properties.

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Mar 25, 2026
@ligfx ligfx requested a review from askumar27 March 25, 2026 00:36
@github-actions
Copy link
Contributor

Linear: ING-2061

@ligfx ligfx changed the title Revert "fix(ingest/mssql): lowercase field paths when convert_urns_to_lowercase=True (#16736)" fix: Revert "fix(ingest/mssql): lowercase field paths when convert_urns_to_lowercase=True (#16736)" Mar 25, 2026
@datahub-project datahub-project deleted a comment from github-actions bot Mar 25, 2026
@ligfx ligfx enabled auto-merge (squash) March 25, 2026 00:41
@codecov
Copy link

codecov bot commented Mar 25, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@datahub-connector-tests
Copy link

Connector Tests Results

All connector tests passed for commit 6694dd8

View full test logs →

To skip connector tests, add the skip-connector-tests label (org members only).

Autogenerated by the connector-tests CI pipeline.

@maggiehays maggiehays added the needs-review Label for PRs that need review from a maintainer. label Mar 25, 2026
Copy link
Contributor

@askumar27 askumar27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ligfx ligfx merged commit 3fa391d into master Mar 25, 2026
54 of 55 checks passed
@ligfx ligfx deleted the mm--revert-mssql-lowercase-columns branch March 25, 2026 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ingestion PR or Issue related to the ingestion of metadata needs-review Label for PRs that need review from a maintainer.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants