fix: Windows path separator handling in ignorer + installer improvements #46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The matchDoubleStarPattern function was not normalizing path separators, causing patterns like **/.venv/** to fail on Windows where paths use backslashes. This resulted in .venv directories being indexed despite being in .gitignore or .pommelignore. Changes: - Use explicit strings.ReplaceAll() to convert backslashes to forward slashes in matchDoubleStarPattern (filepath.ToSlash only converts the OS-native separator) - Add handling for **/.venv/** style patterns (directory with content) - Add handling for .venv/** patterns (without leading **) - Trim trailing slashes to avoid false matches on directory-only paths - Add .venv and venv to default exclude patterns - Add comprehensive cross-platform tests for path separator handling 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
After installation completes, both bash and PowerShell installers now display clear getting started steps: 1. cd <your project directory> 2. pm init 3. pm start Also includes a helpful tip about using 'pm status' to monitor indexing progress while noting that Pommel works with a partial index too. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
.venv/directories were being indexed despite being in ignore patternsmatchDoubleStarPatternto handle Windows backslashes.venvandvenvto default exclude patternsChanges
internal/daemon/ignorer.go: Use explicitstrings.ReplaceAll(path, "\\", "/")for cross-platform path normalizationinternal/config/defaults.go: Add**/.venv/**and**/venv/**to default exclude patternsscripts/install.shandscripts/install.ps1: Add post-install getting started instructionsTest plan
🤖 Generated with Claude Code