-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Deepin-Kernel-SIG] [Backport] [linux 6.6-y] Backport some commits by Uniontech in v6.14-rc3 #600
[Deepin-Kernel-SIG] [Backport] [linux 6.6-y] Backport some commits by Uniontech in v6.14-rc3 #600
Conversation
Reviewer's Guide by SourceryThis pull request removes the notifier chain related to Updated class diagram for cpu-info.hclassDiagram
class cpu-info.h {
<<removed>>
-register_proc_cpuinfo_notifier(struct notifier_block *nb)
<<removed>>
-proc_cpuinfo_notifier_call_chain(unsigned long val, void *v)
<<removed>>
-proc_cpuinfo_notifier(fn, pri)
<<removed>>
-proc_cpuinfo_notifier_args
}
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
[ Upstream commit 03a99d16e64fad41c8d39700bef9b0ac9c4e148b ] Remove hard-coded strings by using the str_yes_no() helper function. Similar to commit c4a0a4a45a45 ("MIPS: kernel: proc: Use str_yes_no() helper function"). Co-developed-by: Wentao Guan <[email protected]> Signed-off-by: Wentao Guan <[email protected]> Signed-off-by: Yuli Wang <[email protected]> Signed-off-by: Huacai Chen <[email protected]> [ Backport from v6.14-rc3 ] Signed-off-by: WangYuli <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Avenger-285714 - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider using
seq_puts
instead ofseq_printf
when printing constant strings to improve performance.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
[ Upstream commit 6b72cd9ef062702390fc96c469beea1729a5dffe ] The notifier hook mechanism in proc and cpuinfo is actually unnecessary for LoongArch because it's not used anywhere. It was originally added to the MIPS code in commit d6d3c9a ("MIPS: MT: proc: Add support for printing VPE and TC ids"), and LoongArch then inherited it. But as the kernel code stands now, this notifier hook mechanism doesn't really make sense for either LoongArch or MIPS. In addition, the seq_file forward declaration needs to be moved to its proper place, as only the show_ipi_list() function in smp.c requires it. Co-developed-by: Wentao Guan <[email protected]> Signed-off-by: Wentao Guan <[email protected]> Signed-off-by: Yuli Wang <[email protected]> Signed-off-by: Huacai Chen <[email protected]> [ Backport from v6.14-rc3 ] Signed-off-by: WangYuli <[email protected]>
d73e189
to
cd8b1ef
Compare
550800a
into
deepin-community:linux-6.6.y
Summary by Sourcery
Enhancements: