Standard for index discovery from ledgers #106
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bogwar
changed the title
aterga
reviewed
Nov 19, 2024
aterga
reviewed
Nov 19, 2024
aterga
reviewed
Nov 19, 2024
aterga
reviewed
Nov 19, 2024
aterga
reviewed
Nov 19, 2024
aterga
reviewed
Nov 19, 2024
aterga
reviewed
Nov 19, 2024
aterga
reviewed
Nov 19, 2024
aterga
reviewed
Nov 19, 2024
aterga
reviewed
Nov 19, 2024
aterga
reviewed
Nov 19, 2024
aterga
reviewed
Nov 19, 2024
aterga
reviewed
Nov 19, 2024
aterga
reviewed
Nov 19, 2024
aterga
reviewed
Nov 19, 2024
aterga
reviewed
Nov 19, 2024
aterga
reviewed
Nov 19, 2024
aterga
reviewed
Nov 19, 2024
aterga
reviewed
Nov 19, 2024
aterga
reviewed
Nov 19, 2024
aterga
reviewed
Nov 19, 2024
aterga
reviewed
Nov 19, 2024
Co-authored-by: Arshavir Ter-Gabrielyan <[email protected]>
Co-authored-by: Arshavir Ter-Gabrielyan <[email protected]>
Co-authored-by: Arshavir Ter-Gabrielyan <[email protected]>
Contributor
|
LGTM! |
Co-authored-by: Arshavir Ter-Gabrielyan <[email protected]>
Co-authored-by: Arshavir Ter-Gabrielyan <[email protected]>
Co-authored-by: Arshavir Ter-Gabrielyan <[email protected]>
Co-authored-by: Arshavir Ter-Gabrielyan <[email protected]>
aterga
reviewed
Nov 26, 2024
Collaborator
Author
|
I'm closing this PR in favour of: dfinity/ICRC-1#196 since this changes cannot be merged into the main ICRCs repo (since we don't plan to finalise this draft) |
github-merge-queue bot
pushed a commit
to dfinity/ic
that referenced
this pull request
Apr 30, 2025
…okens (#3368) We already have `type Tokens = nat`. This PR proposes changing the type of the `fee` and `amount` fields from `nat` to `Tokens` to be more consistent and clear, based on [comments on the ICRC-106 standard](dfinity/ICRC#106 (comment)).
github-merge-queue bot
pushed a commit
to dfinity/ic
that referenced
this pull request
Jun 6, 2025
) Implement [ICRC-106](dfinity/ICRC-1#196) (relocated from [here](dfinity/ICRC#106)) in the ICRC ledger.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A standard to allow for the discovery of the index canister from the corresponding ledger. This standard will exist in draft form only since we will work on a proper ICRC standard for index canisters (which will include discoverability).
A secondary goal for the standard is to document the interface of the current index canister.