feat(ICRC_Ledger): FI-1592: Implement ICRC-106 in the ICRC ledger #2857
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ledger # Conflicts: # rs/ethereum/ledger-suite-orchestrator/src/scheduler/mod.rs # rs/ledger_suite/icrc1/ledger/src/lib.rs # rs/ledger_suite/icrc1/ledger/src/tests.rs # rs/ledger_suite/icrc1/ledger/tests/tests.rs # rs/ledger_suite/tests/sm-tests/src/lib.rs
…ledger # Conflicts: # rs/ledger_suite/icrc1/ledger/tests/tests.rs
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
If this pull request affects the behavior of any canister owned by
the Governance team, remember to update the corresponding
unreleased_changes.md file(s).
To acknowldge this reminder (and unblock the PR), dismiss this
code review by going to the bottom of the pull request page, and
supply one of the following reasons:
-
Done.
-
No canister behavior changes.
Contributor
gregorydemay
left a comment
gregorydemay
left a comment
There was a problem hiding this comment.
I only looked at the part owned by the cross-chain team and I have some understanding question.
mbjorkqvist
added
the
CI_ALL_BAZEL_TARGETS
…ledger # Conflicts: # rs/ledger_suite/icrc1/ledger/tests/tests.rs
maciejdfinity
approved these changes
May 19, 2025
…ledger # Conflicts: # packages/icrc-ledger-types/src/lib.rs # rs/ethereum/ledger-suite-orchestrator/tests/tests.rs # rs/ledger_suite/icrc1/ledger/ledger.did # rs/ledger_suite/icrc1/ledger/src/lib.rs # rs/ledger_suite/icrc1/ledger/src/main.rs # rs/ledger_suite/tests/sm-tests/src/lib.rs
aterga
approved these changes
Jun 6, 2025
marko-k0
approved these changes
Jun 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement ICRC-106 (relocated from here) in the ICRC ledger.