feat(ICRC_Ledger): FI-1604: Set index in existing SNS and ck ledgers #5237
Conversation
…ledger # Conflicts: # rs/ethereum/ledger-suite-orchestrator/src/scheduler/mod.rs # rs/ledger_suite/icrc1/ledger/src/lib.rs # rs/ledger_suite/icrc1/ledger/src/tests.rs # rs/ledger_suite/icrc1/ledger/tests/tests.rs # rs/ledger_suite/tests/sm-tests/src/lib.rs
…ledger # Conflicts: # rs/ledger_suite/icrc1/ledger/tests/tests.rs
…ledger # Conflicts: # rs/ledger_suite/icrc1/ledger/tests/tests.rs
|
Approved from the perspective of the SNS Ledger migration. Thanks! Just one more ask, which could be done in a follow-up PR if easier: Could you please add comments, e.g.,
So that we keep track of the temporary migrations code, simplifying a future cleanup. |
gregorydemay
left a comment
gregorydemay
left a comment
There was a problem hiding this comment.
Thanks a lot @mbjorkqvist for this PR and sorry for the delayed review. A minor comment from my side.
…mathias-FI-1604-set-index-in-existing-sns-ledgers # Conflicts: # publish/canisters/BUILD.bazel
…ledgers # Conflicts: # rs/ledger_suite/icrc1/ledger/tests/tests.rs # rs/ledger_suite/tests/sm-tests/src/icrc_106.rs
Good idea! I added a |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
mbjorkqvist
deleted the
mathias-FI-1604-set-index-in-existing-sns-ledgers
branch
5 participants
Set the index canister principal ID in the ledgers of the SNS and chain fusion ledgers.