-
Notifications
You must be signed in to change notification settings - Fork 372
feat(ICRC_Ledger): FI-1604: Set index in existing SNS and ck ledgers #5237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
mbjorkqvist
merged 56 commits into
master
from
mathias-FI-1604-set-index-in-existing-sns-ledgers
Jun 19, 2025
Merged
Changes from all commits
Commits
Show all changes
56 commits
Select commit
Hold shift + click to select a range
ac805e3
Add ICRC-106 to supported standards in ICRC ledger
mbjorkqvist 686aad3
Add new types to icrc-ledger-types
mbjorkqvist 48d8100
Add index_principal to upgrade args and add new endpoint
mbjorkqvist 9d6cdb9
Add index principal to metadata
mbjorkqvist 2308795
Clippy
mbjorkqvist 62bfaf6
Candid fixes and renaming
mbjorkqvist a08bb40
Clippy
mbjorkqvist 23df570
Cleanup
mbjorkqvist 18b1b7b
Merge branch 'master' into mathias-FI-1592-implement-icrc106-in-icrc-…
mbjorkqvist ab9c2d0
Support setting index canister ID in ledger init arguments
mbjorkqvist d59a44c
Fixes
mbjorkqvist 509ab75
Clippy
mbjorkqvist d24347a
Merge branch 'master' into mathias-FI-1592-implement-icrc106-in-icrc-…
mbjorkqvist 3b4cc30
Missing field
mbjorkqvist 269a2c6
Merge branch 'master' into mathias-FI-1592-implement-icrc106-in-icrc-…
mbjorkqvist e91b839
Merge branch 'master' into mathias-FI-1592-implement-icrc106-in-icrc-…
mbjorkqvist 9b6bc0c
Merge branch 'master' into mathias-FI-1592-implement-icrc106-in-icrc-…
mbjorkqvist 5631a5c
Merge branch 'master' into mathias-FI-1592-implement-icrc106-in-icrc-…
mbjorkqvist 09467c9
Merge branch 'master' into mathias-FI-1592-implement-icrc106-in-icrc-…
mbjorkqvist 801001d
Merge branch 'master' into mathias-FI-1592-implement-icrc106-in-icrc-…
mbjorkqvist 59c27ed
Set index principal for new chain fusion ledgers
mbjorkqvist f794544
Set index principal for new SNS ledgers
mbjorkqvist 56e4d71
Fix ledger suite orchestrator tests
mbjorkqvist 3ea51bc
Address review comments
mbjorkqvist 361943c
Merge branch 'master' into mathias-FI-1592-implement-icrc106-in-icrc-…
mbjorkqvist 5f5fcd5
Add serde_default to new index_principal field in Ledger struct
mbjorkqvist f78f6fd
Beautify code
mbjorkqvist b3ec415
Clean up and improve tests
mbjorkqvist d993000
Merge branch 'master' into mathias-FI-1592-implement-icrc106-in-icrc-…
mbjorkqvist 3f3699f
Merge branch 'master' into mathias-FI-1592-implement-icrc106-in-icrc-…
mbjorkqvist b97325f
Merge branch 'master' into mathias-FI-1592-implement-icrc106-in-icrc-…
mbjorkqvist 4f1b0f9
Merge branch 'master' into mathias-FI-1592-implement-icrc106-in-icrc-…
mbjorkqvist a981f60
Uncomment annotation
mbjorkqvist 42ff066
Set hardcoded index principal for chain fusion and SNS ledger suites
mbjorkqvist d5e8ad2
Add ck test tokens
mbjorkqvist 4108e28
Clippy
mbjorkqvist c2c58e9
Update SNSs in golden state test
mbjorkqvist ede3216
Bump size limit of ic-icrc1-ledger.wasm.gz
mbjorkqvist 79f17e3
Merge branch 'master' into mathias-FI-1592-implement-icrc106-in-icrc-…
mbjorkqvist 1fb277f
Merge branch 'mathias-FI-1592-implement-icrc106-in-icrc-ledger' into …
mbjorkqvist c5f4fb4
Empty commit to trigger tests
mbjorkqvist 3d0f8b1
Update comment
mbjorkqvist d1c494a
Merge branch 'master' into mathias-FI-1592-implement-icrc106-in-icrc-…
mbjorkqvist b730aa3
Merge branch 'mathias-FI-1592-implement-icrc106-in-icrc-ledger' into …
mbjorkqvist 0233636
Add recently launched TACO DAO SNS and split ledger suites into separ…
mbjorkqvist 90a5556
Rename index principal setting function and adapt rustdoc
mbjorkqvist 8fd2147
Only log an error rather than trapping in case setting the index prin…
mbjorkqvist d796ce9
Add cleanup TODO
mbjorkqvist 91796d5
Merge branch 'master' into mathias-FI-1592-implement-icrc106-in-icrc-…
mbjorkqvist 58460e9
Added SNS governance unreleased_changelog.md entry
mbjorkqvist 413b9c6
Bump ICRC ledger size limit
mbjorkqvist 6a7e93a
Merge branch 'master' into mathias-FI-1592-implement-icrc106-in-icrc-…
mbjorkqvist 1bd7af1
Merge branch 'mathias-FI-1592-implement-icrc106-in-icrc-ledger' into …
mbjorkqvist af7887c
Avoid String to Principal conversions but add unit tests for better h…
mbjorkqvist 897670f
Merge branch 'master' into mathias-FI-1604-set-index-in-existing-sns-…
mbjorkqvist 92aec40
Buildifier
mbjorkqvist File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.