feat(ICRC-Index): add and handle ICRC-107 fee collector blocks #7411
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maciejdfinity
changed the title
maciejdfinity
changed the title
mbjorkqvist
reviewed
Nov 14, 2025
Contributor
mbjorkqvist
left a comment
mbjorkqvist
left a comment
There was a problem hiding this comment.
Thanks @maciejdfinity! I left some initial comments, but I'll make another pass later today/early next week.
Co-authored-by: Mathias Björkqvist <[email protected]>
Co-authored-by: Mathias Björkqvist <[email protected]>
Co-authored-by: Mathias Björkqvist <[email protected]>
mbjorkqvist
reviewed
Nov 17, 2025
Co-authored-by: Mathias Björkqvist <[email protected]>
mbjorkqvist
reviewed
Nov 24, 2025
mbjorkqvist
approved these changes
Nov 24, 2025
jasonz-dfinity
approved these changes
Nov 24, 2025
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 26, 2025
… block types (#7795) The archive does not process the transactions, so the only thing needed for it to support `107feecol` block types is to add the fee collector block to `icrc_ledger_types::Transaction` and the `archive.did` file (done as part of #7411) and return `107feecol` in the list of supported block types.
mraszyk
pushed a commit
that referenced
this pull request
Dec 1, 2025
Introduce the ICRC-107 fee collector operation to the ICRC ledger blocks and implement handling of the operation in the ICRC index. Since the ledger does not produce the new blocks yet, the index handling is tested using the icrc3 test ledger. The blocks structure and handling is implemented according the the ICRC-107 standard as defined in dfinity/ICRC#117. Although the standard allows for 107 blocks to skip the `tx` entirely, we require the `tx` and the field `tx.op` to be present in the block. --------- Co-authored-by: Mathias Björkqvist <[email protected]>
mraszyk
pushed a commit
that referenced
this pull request
Dec 1, 2025
… block types (#7795) The archive does not process the transactions, so the only thing needed for it to support `107feecol` block types is to add the fee collector block to `icrc_ledger_types::Transaction` and the `archive.did` file (done as part of #7411) and return `107feecol` in the list of supported block types.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce the ICRC-107 fee collector operation to the ICRC ledger blocks and implement handling of the operation in the ICRC index. Since the ledger does not produce the new blocks yet, the index handling is tested using the icrc3 test ledger. The blocks structure and handling is implemented according the the ICRC-107 standard as defined in dfinity/ICRC#117. Although the standard allows for 107 blocks to skip the
txentirely, we require thetxand the fieldtx.opto be present in the block.