-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
changed return response of Registerview to throw valid error message and added validation for email id #123
changed return response of Registerview to throw valid error message and added validation for email id #123
Conversation
@Sachin-chaurasiya can you tag the issue here please? |
yeah sure. |
Looks good to me. I was about to submit the PR since I was assigned to that issue before I saw yours. Great work. |
Thank you 😊 |
Apologies @itzomen for this. I didn't check the issue assignment Much appreciated with your work but please be considerate of the other developers. Thank you for understanding. |
My apology to @itzomen . |
As we are rendering all responses with detail so we need to add detail here also instead of message!
Ohh I see thank you for correction. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now looks good!
Good job Sachin !
Thank you @PraveenMalethia |
No prob, Great Job |
…sages
Describe your changes :
I worked on the Response of Register view because there are no attribute messages for the Response method so I have changed the
messages=messages
to{"messages":messages}
.Type of change :
Preview (Screenshots) :
If it is possible, please link screenshots of your changes preview !
Checklist:
Reviewers
Backend: @abhivemp, @divanov11