Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed return response of Registerview to throw valid error message and added validation for email id #123

Merged
merged 3 commits into from
May 15, 2021

Conversation

Sachin-chaurasiya
Copy link
Contributor

…sages

Describe your changes :


I worked on the Response of Register view because there are no attribute messages for the Response method so I have changed the messages=messages to {"messages":messages}.

Type of change :

  • Bug fix

Preview (Screenshots) :

If it is possible, please link screenshots of your changes preview !

Checklist:

  • I have read the Code Of Conduct document.
  • I have read the CONTRIBUTING document.
  • I have performed a self-review of my own.
  • I have tagged my reviewers below.
  • I have commented my code, particularly in hard-to-understand areas.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • All new and existing tests passed.

Reviewers

Backend: @abhivemp, @divanov11

@Sachin-chaurasiya Sachin-chaurasiya changed the title changed return response of Registerview when to throw valid error mes… changed return response of Registerview when to throw valid error message and added validation for email id May 15, 2021
@Sachin-chaurasiya Sachin-chaurasiya changed the title changed return response of Registerview when to throw valid error message and added validation for email id changed return response of Registerview to throw valid error message and added validation for email id May 15, 2021
@abhivemp
Copy link
Collaborator

@Sachin-chaurasiya can you tag the issue here please?

@Sachin-chaurasiya
Copy link
Contributor Author

yeah sure.
#96

@abhivemp abhivemp linked an issue May 15, 2021 that may be closed by this pull request
@itzomen
Copy link
Contributor

itzomen commented May 15, 2021

yeah sure.
#96

Looks good to me. I was about to submit the PR since I was assigned to that issue before I saw yours. Great work.
To keep things organized it's cool to get assigned before working on an issue

@Sachin-chaurasiya
Copy link
Contributor Author

Thank you 😊
Next time for sure

@abhivemp
Copy link
Collaborator

abhivemp commented May 15, 2021

Thank you 😊
Next time for sure

Apologies @itzomen for this. I didn't check the issue assignment
@Sachin-chaurasiya please read the contributing guidelines. You are work on an issue if its assigned to you. Not doing so makes two people work on the same thing ans we have to scrap one person's hard work.

Much appreciated with your work but please be considerate of the other developers. Thank you for understanding.

@Sachin-chaurasiya
Copy link
Contributor Author

Sachin-chaurasiya commented May 15, 2021

My apology to @itzomen .

As we are rendering all responses with detail so we need to add detail here also instead of message!
@Sachin-chaurasiya
Copy link
Contributor Author

Ohh I see thank you for correction.

Copy link
Collaborator

@PraveenMalethia PraveenMalethia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now looks good!
Good job Sachin !

@Sachin-chaurasiya
Copy link
Contributor Author

Thank you @PraveenMalethia

@PraveenMalethia PraveenMalethia merged commit b39ed94 into divanov11:master May 15, 2021
@itzomen
Copy link
Contributor

itzomen commented May 15, 2021

My apology to @itzomen .

No prob, Great Job

@Sachin-chaurasiya Sachin-chaurasiya deleted the responses branch May 15, 2021 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

With same email I can register multiple user
4 participants