Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed return response of Registerview to throw valid error message and added validation for email id #123

Merged
merged 3 commits into from
May 15, 2021
Merged

changed return response of Registerview to throw valid error message and added validation for email id #123

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
79f07ed
changed return response of Registerview when to throw valid error mes…
Sachin-chaurasiya May 15, 2021
d739997
added validation for email id
Sachin-chaurasiya May 15, 2021
a642545
response consistency
PraveenMalethia May 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion users/views.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,8 +51,10 @@ def post(self, request):
messages['errors'].append('Email can\'t be empty')
if password == None:
messages['errors'].append('Password can\'t be empty')
if User.objects.filter(email=email).exists():
messages['errors'].append("Account already exists with this email id.")
if len(messages['errors']) > 0:
return Response(messages=messages,status=status.HTTP_400_BAD_REQUEST)
return Response({"detail":messages['errors']},status=status.HTTP_400_BAD_REQUEST)
try:
user = User.objects.create(
username=username,
Expand Down