Skip to content

fix: cap advertised resumable chunk size to route limit#2

Closed
rabble wants to merge 3 commits into
mainfrom
fix-resumable-ingress-contract
Closed

fix: cap advertised resumable chunk size to route limit#2
rabble wants to merge 3 commits into
mainfrom
fix-resumable-ingress-contract

Conversation

@rabble
Copy link
Copy Markdown
Member

@rabble rabble commented Mar 29, 2026

Summary

  • cap advertised resumable chunk size to the configured upload-route body limit
  • add a regression test proving the server never advertises a chunk larger than the route can accept
  • document the new RESUMABLE_MAX_REQUEST_BODY_SIZE env var

Test Plan

  • cargo test --manifest-path /Users/rabble/code/divine/divine-upload-server/.worktrees/fix-resumable-ingress-contract/Cargo.toml

@NotThatKindOfDrLiz
Copy link
Copy Markdown
Member

Closing as superseded by PR #1 (5303eeb), plus follow-up fixes in PR #3 and PR #4. The docs and ignore changes from this branch are already on main, and the remaining code here is stale relative to the current resumable upload behavior.

1 similar comment
@NotThatKindOfDrLiz
Copy link
Copy Markdown
Member

Closing as superseded by PR #1 (5303eeb), plus follow-up fixes in PR #3 and PR #4. The docs and ignore changes from this branch are already on main, and the remaining code here is stale relative to the current resumable upload behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants