Repository navigation
Conversation
The Velocity Playground's grammar moves to @dotcms/ui and merges with the content editor's HTML-aware one, so the playground, the content editor's code fields and its file editor highlight Velocity the same way. Velocity is coloured in text, tags and attribute values; strings, numbers and operators only inside Velocity expressions, so an apostrophe in prose no longer starts a string. Multi-line #* *# comments are coloured too. The language keeps the velocity id the content editor already stores, and edit-content's own grammar is removed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Claude finished @fmontes's task in 2m 12s —— View job Claude's Review — one Velocity grammar for every Monaco editor
This is a clean consolidation: three divergent Velocity grammars (edit-content's
New Issues
No blocking issues found — the Medium above is a behavior check, not a defect. The console.warn("Monaco is not available globally") that |
Proposed Changes
@dotcms/ui(ui/src/lib/monaco/velocity-language.ts). The Velocity Playground, the content editor's code fields and its file editor all register it withensureDotVelocityLanguageRegistered().<script>and<style>), and the playground's, which coloured strings, numbers, operators and method calls.#* *#comments are coloured too.velocity, the id the content editor already stores and detects. The playground's id changes fromvelocity-playgroundtovelocity.custom-languages/) is removed. Its HTML rules move toui/src/lib/monaco/velocity-html-tokenizer.ts.monacoMockgainsgetLanguages, which real Monaco has.Checklist
Additional Info
monaco.editor.tokenizeon a sample template: comments, Velocity inside tags and attribute values, expressions,${…}references and#dotParsepaths are coloured; apostrophes in prose,$5and#hashtagstay plain text.Refs #37965
🤖 Generated with Claude Code