Enable more tests to run on all 3 runtimes, part 12 #10632
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grendello
force-pushed
the
dev/grendel/test-runtimes-12
branch
from
1b1c798 to
32bd8e8
Compare
grendello
force-pushed
the
dev/grendel/test-runtimes-12
branch
from
769988d to
8c71aeb
Compare
grendello
force-pushed
the
dev/grendel/test-runtimes-12
branch
from
8c71aeb to
e09ef40
Compare
Member
jonathanpeppers
left a comment
jonathanpeppers
left a comment
There was a problem hiding this comment.
I reran the WearOS 1 tests, but I wonder if they are failing because the Android Wear emulator is 32-bit?
It's probably ok if they pass on rerun.
There was a problem hiding this comment.
Pull request overview
This pull request extends runtime testing capabilities by enabling more tests to run across all three Android runtimes (MonoVM, CoreCLR, and NativeAOT). The changes are part 12 of a larger effort to ensure comprehensive runtime test coverage.
Key Changes:
- Refactored test parameters to use
[Values] AndroidRuntimeinstead of hardcoded runtime values, enabling tests to run with all available runtimes - Converted static test case arrays to dynamic test case generators that iterate through runtime enumerations
- Added NativeAOT-specific handling for file paths and test assertions, with appropriate ignore conditions for currently unsupported scenarios
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| tests/MSBuildDeviceIntegration/Tests/DebuggingTest.cs | Extended ApplicationRunsWithoutDebugger, ClassLibraryMainLauncherRuns, CustomApplicationRunsWithDebuggerAndBreaks, and ApplicationRunsWithDebuggerAndBreaks tests to support all runtimes; converted static test case arrays to dynamic generators; added NativeAOT-specific ignore conditions with detailed TODO comments |
| tests/MSBuildDeviceIntegration/Tests/BundleToolTests.cs | Updated fixture arguments to iterate through all runtime values using Enum.GetValues; added NativeAOT-specific file expectations for libUnnamedProject.so in bundle tests |
| tests/MSBuildDeviceIntegration/Tests/BundleToolNoAbiSplitTests.cs | Converted from individual [TestFixture] attributes to [TestFixtureSource] for dynamic runtime enumeration; added NativeAOT-specific handling for ApplicationConfig checks and environment file gathering; added test ignore for NativeAOT InvalidCastException |
| src/Xamarin.Android.Build.Tasks/Tests/Xamarin.Android.Build.Tests/Utilities/EnvironmentHelper.cs | Added runtime parameter to GatherEnvironmentFiles method with CoreCLR default for backward compatibility; implemented NativeAOT-specific path handling using MonoAndroidHelper.AbiToRid for RID-prefixed directories |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.