fix warnings in templates #32180
Open
fix warnings in templates #32180
+8
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR addresses compiler warnings in the MAUI mobile template by fixing event handler signatures to properly handle nullable sender parameters and suppressing deprecation warnings for styles that use deprecated APIs.
Key Changes:
- Updated event handler signatures to accept nullable
object?sender parameters - Added null-safety checks when casting and accessing the sender object
- Suppressed deprecation warnings (0618) for AppStyles.xaml that uses deprecated APIs
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/Templates/src/templates/maui-mobile/Pages/Controls/TaskView.xaml.cs | Updated CheckBox_CheckedChanged event handler to use nullable sender and added null-safety checks |
| src/Templates/src/templates/maui-mobile/MauiApp.1.csproj | Added NoWarn directive to suppress deprecation warnings for AppStyles.xaml |
| src/Templates/src/templates/maui-mobile/AppShell.xaml.cs | Updated SfSegmentedControl_SelectionChanged event handler to accept nullable sender parameter |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
sample content template uses deprecated API and has wrong event handlers signatures, triggering warnings with XSG. Ignore the deprecation, fix the signature