docs: codify repository responsibility map and extension points (#413)#421
Merged
Conversation
Close the four acceptance criteria for #413 by extending the existing responsibility-map.md (not recreating it): - Add a "Supporting Libraries" subsection for 8 submodules (text-change, moji, pretty, order-tree, rle, alga, graphviz, svg-dsl), grouped by verified integration layer from moon.mod.json (root deps / via event-graph-walker / visualization tooling). - Split "Current Stance" into Implemented (code-backed) vs Planned / Aspirational, clarifying incr's current incremental-projection use vs its planned semantic-pipeline expansion. - Add a "Source of Truth on Drift" rule: code + generated .mbti are authoritative; api-map.md is a reuse index, not authority. - Add cross-links to architecture.md, api-map.md, and theory notes instead of duplicating; add an Owner Selection / Reuse First flow. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| 🔵 In progress View logs |
lambda-editor | 5c1b4c1 | May 31 2026, 11:05 AM |
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
lambda-editor | ef9b4f9 | Commit Preview URL Branch Preview URL |
May 31 2026, 11:11 AM |
|
Warning Review limit reached
More reviews will be available in 54 minutes and 46 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughUpdated ChangesArchitecture Documentation Update
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5c1b4c1bb5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Comment on lines
+77
to
+81
| ## Supporting Libraries (submodules) | ||
|
|
||
| All 8 libraries below are implemented and wired into Canopy. Sources: canopy root | ||
| `moon.mod.json` (group A); `event-graph-walker`'s deps (group B); and | ||
| visualization/example modules plus `graphviz`'s own deps (group C). |
There was a problem hiding this comment.
This section is labeled as a submodule owner map, but the root .gitmodules contains event-graph-walker, loom, svg-dsl, graphviz, rle, order-tree, alga, and rabbita; text-change, moji, and pretty are packages under the loom submodule, while rabbita is omitted entirely. Because this document is now the ownership decision guide, contributors following it for submodule updates or ownership routing will target the wrong repository boundaries and miss the actual Rabbita submodule.
Useful? React with 👍 / 👎.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/architecture/responsibility-map.md`:
- Around line 116-117: Update the responsibility-map entry for issue `#418` so it
no longer claims a 0.5.x→0.6 migration is merely "planned" when the code already
depends on dowdiness/incr@0.6.0 (see lib/cognition/moon.mod); instead, reword
the item to state what remaining work is planned on top of v0.6 (for example,
"facade stabilization/completion, integration tests, and cleanup") so the
roadmap accurately reflects that the repo has adopted v0.6 but still requires
additional facade stabilization tasks.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 3ae1b788-0df1-4d7d-a5ee-377a4bf0c78d
📒 Files selected for processing (1)
docs/architecture/responsibility-map.md
Comment on lines
116
to
+117
| 4. [#418](https://github.com/dowdiness/canopy/issues/418) - plan migration | ||
| from `incr` 0.5.x to the 0.6 target facade. | ||
| from `incr` 0.5.x to the 0.6 target facade. *(planned)* |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Verify current incr versions and migration wording references.
rg -n -C2 'dowdiness/incr@|incr 0\.5|0\.6 target facade|`#418`'Repository: dowdiness/canopy
Length of output: 1757
Clarify incr migration baseline for #418 to avoid roadmap drift.
Line 117 states the migration from incr 0.5.x → 0.6 target facade is (planned), but the current code already references dowdiness/incr@0.6.0 in lib/cognition/moon.mod. Reword #418 to describe what’s still planned on top of 0.6 (e.g., facade stabilization/completion) so the roadmap matches reality.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@docs/architecture/responsibility-map.md` around lines 116 - 117, Update the
responsibility-map entry for issue `#418` so it no longer claims a 0.5.x→0.6
migration is merely "planned" when the code already depends on
dowdiness/incr@0.6.0 (see lib/cognition/moon.mod); instead, reword the item to
state what remaining work is planned on top of v0.6 (for example, "facade
stabilization/completion, integration tests, and cleanup") so the roadmap
accurately reflects that the repo has adopted v0.6 but still requires additional
facade stabilization tasks.
Address P2 review finding: the Supporting Libraries section conflated git submodules with loom-internal packages and omitted rabbita. - List the actual submodule boundaries from .gitmodules (incl. rabbita), and note loom is itself a submodule containing seam/incr/text-change/moji/ pretty/lambda as packages. - Add a Repository column marking text-change/moji/pretty as packages inside the loom submodule (not standalone repos) vs standalone submodules. - Add rabbita (moonbit-community/rabbita Web UI framework, wired via lib/rabbita_codemirror) to Group C. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Benchmark Comparison ReportComparing PR branch against Main Module BenchmarksBase branch: PR branch: event-graph-walker BenchmarksBase branch: PR branch: Benchmarks run with |
This was referenced May 31, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #413.
Extends the existing
docs/architecture/responsibility-map.md(does not recreate it) to meet all four acceptance criteria:text-change,moji,pretty,order-tree,rle,alga,graphviz,svg-dsl), grouped by verified integration layer; plus an "Owner Selection / Reuse First" lookup flow.@incrclarified: incremental projection is implemented today, the general semantic pipeline is planned.architecture.md,api-map.md,modules.md, and theory notes instead of restating them..mbtiare authoritative;api-map.mdis a reuse index.Out of scope respected: no code refactor, no rewriting other docs, no moving submodule docs into Canopy.
Follow-up (not in this PR's scope):
docs/architecture/modules.mdis stale — it omits several current root deps (order-tree,alga,pretty,byte_codec,zipper,egglog,egraph). Worth a separate issue; this is itself an instance of the doc-drift AC4 addresses.🤖 Generated with Claude Code
Summary by CodeRabbit