Conversation
…class Remove the deprecated compile() method on Compiler — all callers now use dialect.compile() directly. Also remove the Param class, its render method, and the cv_params context variable, as nothing in the codebase ever instantiates Param. Closes #7, closes #10 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The params argument was left behind after removing the Param/cv_params system — it was silently accepted but never used. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Compiler.compile()wrapper method. All callers (tests) now usedialect.compile()directly, matching production code.Paramclass, itsrender_parammethod, thecv_paramscontext variable, and thecontextvarsimport — nothing in the codebase ever instantiatesParam.ast_classes.py(useX | Yinstead of(X, Y)inisinstance).Closes #7, closes #10
Test plan
test_query.pytests pass (updated to usedialect.compile())test_mssql.pytests passtest_sql.pytests require live MySQL — pre-existing, unrelated to this changegrep -r 'Param' data_diff/returns no matches🤖 Generated with Claude Code